Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sop #9873

Closed
wants to merge 20 commits into from

Conversation

Projects
None yet
6 participants
@Immortalem
Copy link

Immortalem commented Mar 6, 2018

Added the test cases from your-sop.com

@wpt-pr-bot

This comment has been minimized.

Copy link
Collaborator

wpt-pr-bot commented Mar 6, 2018

There are no owners for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 6, 2018

Build PASSED

Started: 2018-03-06 15:47:01
Finished: 2018-03-06 16:02:47

Failing Jobs

  • MicrosoftEdge:16.16299
  • safari:11.0

Unstable Results

Browser: "Safari 11.0" (failures allowed)

View in: WPT PR Status | TravisCI

Test Subtest Results Messages
/sop/AUDIO.sub.html   TIMEOUT: 10
  AUDIO - partial cross-origin read NOTRUN: 8
  AUDIO - partial same-origin read NOTRUN: 8
/sop/CANVAS_mp4ogg.sub.html   TIMEOUT: 10
  CANVAS - MP4OGG - cross-origin - CO: anonymous, O: A, UC: false NOTRUN: 8
  CANVAS - MP4OGG - cross-origin - CO: anonymous, O: A, UC: Not Set NOTRUN: 8
  CANVAS - MP4OGG - cross-origin - CO: anonymous, O: A, UC: true NOTRUN: 8
  CANVAS - MP4OGG - cross-origin - CO: anonymous, O: wildcard, UC: false NOTRUN: 8
  CANVAS - MP4OGG - cross-origin - CO: anonymous, O: wildcard, UC: Not Set NOTRUN: 8
  CANVAS - MP4OGG - cross-origin - CO: anonymous, O: wildcard, UC: true NOTRUN: 8
  CANVAS - MP4OGG - cross-origin - CO: Not Set, O: A, UC: false NOTRUN: 8
  CANVAS - MP4OGG - cross-origin - CO: Not Set, O: A, UC: Not Set NOTRUN: 8
  CANVAS - MP4OGG - cross-origin - CO: Not Set, O: A, UC: true NOTRUN: 8
  CANVAS - MP4OGG - cross-origin - CO: Not Set, O: B, UC: false NOTRUN: 8
  CANVAS - MP4OGG - cross-origin - CO: Not Set, O: B, UC: Not Set NOTRUN: 8
  CANVAS - MP4OGG - cross-origin - CO: Not Set, O: B, UC: true NOTRUN: 8
  CANVAS - MP4OGG - cross-origin - CO: Not Set, O: Not Set, UC: false NOTRUN: 8
  CANVAS - MP4OGG - cross-origin - CO: Not Set, O: Not Set, UC: Not Set NOTRUN: 8
  CANVAS - MP4OGG - cross-origin - CO: Not Set, O: Not Set, UC: true NOTRUN: 8
  CANVAS - MP4OGG - cross-origin - CO: Not Set, O: wildcard, UC: false NOTRUN: 8
  CANVAS - MP4OGG - cross-origin - CO: Not Set, O: wildcard, UC: Not Set NOTRUN: 8
  CANVAS - MP4OGG - cross-origin - CO: Not Set, O: wildcard, UC: true NOTRUN: 8
  CANVAS - MP4OGG - cross-origin - CO: use-credentials, O: A, UC: true NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: anonymous, O: A, UC: false NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: anonymous, O: A, UC: Not Set NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: anonymous, O: A, UC: true NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: anonymous, O: B, UC: false NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: anonymous, O: B, UC: Not Set NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: anonymous, O: B, UC: true NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: anonymous, O: Not Set, UC: false NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: anonymous, O: Not Set, UC: Not Set NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: anonymous, O: Not Set, UC: true NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: anonymous, O: wildcard, UC: false NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: anonymous, O: wildcard, UC: Not Set NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: anonymous, O: wildcard, UC: true NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: Not Set, O: A, UC: false NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: Not Set, O: A, UC: Not Set NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: Not Set, O: A, UC: true NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: Not Set, O: B, UC: false NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: Not Set, O: B, UC: Not Set NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: Not Set, O: B, UC: true NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: Not Set, O: Not Set, UC: false NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: Not Set, O: Not Set, UC: Not Set NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: Not Set, O: Not Set, UC: true NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: Not Set, O: wildcard, UC: false NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: Not Set, O: wildcard, UC: Not Set NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: Not Set, O: wildcard, UC: true NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: use-credentials, O: A, UC: false NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: use-credentials, O: A, UC: Not Set NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: use-credentials, O: A, UC: true NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: use-credentials, O: B, UC: false NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: use-credentials, O: B, UC: Not Set NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: use-credentials, O: B, UC: true NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: use-credentials, O: Not Set, UC: false NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: use-credentials, O: Not Set, UC: Not Set NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: use-credentials, O: Not Set, UC: true NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: use-credentials, O: wildcard, UC: false NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: use-credentials, O: wildcard, UC: Not Set NOTRUN: 8
  CANVAS - MP4OGG - same-origin - CO: use-credentials, O: wildcard, UC: true NOTRUN: 8

@gsnedders gsnedders requested review from domenic and annevk Mar 6, 2018

@annevk

This comment has been minimized.

Copy link
Member

annevk commented Apr 23, 2018

Thanks for submitting these tests! And sorry for taking so long to get back to you.

It seems like these tests are generated, is that the case? In that case it might be more beneficial to commit the script that generates these so it's easier to fix things up.

There's also a lot of code duplication making this hard to review.

When I run these in nightly builds of browsers there's also a couple of timeouts here and there. Are there bugs for those on file?

I think we also don't want to put these in a top-level sop/ directory, given how web-platform-tests is structured. If they're all related to fetching we could potentially put them in fetch/same-origin-policy/, but otherwise I'd just put them in the respective HTML directories.

@Immortalem

This comment has been minimized.

Copy link
Author

Immortalem commented Apr 23, 2018

You're right spot of the code was generated with a python script. But that's only for the boiler plate code. The code for the specific behavior (assertions or using onload vs. not doing so) were fixed up manually.

But obviously it wouldn't be a problem to also submit the file used to generate some of the code.

Honestly I didn't test it on the nightly builds. I'll do that tomorrow when I got time. But if there are timeouts it could be due to the resources not being loaded.

And I'm not quite sure regarding the placement. I don't think fetch is the right place either since the test cases do not test if the resources are loaded but which privileges are obtained when loading them.

Well in some way that might even relate to fetch. So yeah I'm not entirely sure where to put them.

@zcorpan

This comment has been minimized.

Copy link
Contributor

zcorpan commented Apr 24, 2018

Should these be somewhere under html/ instead? Should this set of tests have its own OWNERS file?

@annevk

This comment has been minimized.

Copy link
Member

annevk commented Apr 25, 2018

Yeah, I think we should put them in html/ somewhere given the features it's testing.

@Immortalem

This comment has been minimized.

Copy link
Author

Immortalem commented Apr 25, 2018

Ok, so I ran the test cases in Chrome Version 68.0.3406.0 (Official Build) canary (64-bit) [Windows] but there weren't any timeouts. Which version did you use annevk, and how did you run the test cases ?

It seems the general census is to move the test cases to their respective HTML elements.

A question that still persists is how I should handle the python resources I created and need. Should I place them somewhere central or have them multiple times, once for every HTML element.

Another question is: While the test cases are specific in some parts I think it should be possible to remove some boiler plate code by generating the test cases with python. That said there won't be a mapping of one file HTML (currently) to one file python (then). It would be more like 2-3 files. But that shouldn't be a problem, since it after all reduces the boiler plate code. There might be even a solution with a one to one mapping I'd have to look into it.
Anyway, getting to the point, shall I commit the current version into the respective HTML directories and rework the code afterwards or should I rework the code first and commit then ?

Kind Regards
Mario

@annevk

This comment has been minimized.

Copy link
Member

annevk commented Apr 25, 2018

Chrome 68.0.3406.0 (with experimental features enabled) on macOS (latest stable). I get timeouts on CANVAS_png.sub.html, CANVAS_svg.sub.html, IFRAME_html_sandbox.sub.html (a harness timeout, no test timeout), and LINK.sub.html.

You should feel free to put the common files for these tests in https://github.com/w3c/web-platform-tests/tree/master/html/resources.

@annevk

This comment has been minimized.

Copy link
Member

annevk commented Apr 25, 2018

Anyway, getting to the point, shall I commit the current version into the respective HTML directories and rework the code afterwards or should I rework the code first and commit then ?

That's really up to you I think. I'd like to start reviewing again once all is in order though, but happy to assist with further questions.

@Immortalem

This comment has been minimized.

Copy link
Author

Immortalem commented May 3, 2018

Due to several reasons I'm currently running a bit short on time. Never the less, I'm trying to slowly change to code and move it to where it belongs. I looked in html/ and now I'm not quite sure how exactly I should place the test cases inside.

I couldn't find any specific folders like CANVAS or IMG. Therefore I was wondering if I should I place them in html/sop/ or in html/dom/sop ? (Testing the DOM-SOP).

Kind Regards
Mario

@annevk

This comment has been minimized.

Copy link
Member

annevk commented May 3, 2018

You'll find directories for the elements you're looking for in html/semantics/embedded-content/.

@Immortalem Immortalem closed this Aug 29, 2018

@Immortalem

This comment has been minimized.

Copy link
Author

Immortalem commented Aug 29, 2018

closed since repository was too old. Will open a new PR soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.