Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require mozdownload and mozinstall when running wpt install. #9875

Merged
merged 1 commit into from Mar 8, 2018

Conversation

Projects
None yet
5 participants
@jgraham
Copy link
Contributor

jgraham commented Mar 6, 2018

mozdownload and mozinstall are now used to install Firefox. Therefore
they are required to run the |wpt install| command.


This change is Reviewable

Require mozdownload and mozinstall when running wpt install.
mozdownload and mozinstall are now used to install Firefox. Therefore
they are required to run the |wpt install| command.

@wpt-pr-bot wpt-pr-bot added the infra label Mar 6, 2018

@wpt-pr-bot wpt-pr-bot requested a review from gsnedders Mar 6, 2018

@gsnedders

This comment has been minimized.

Copy link
Contributor

gsnedders commented Mar 6, 2018

Are they not also required by wpt run for wpt run --install-browser?

@jgraham

This comment has been minimized.

Copy link
Contributor Author

jgraham commented Mar 6, 2018

No, I think the previous PR changed this so that wpt run gets them from the requirements_firefox.txt file.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 6, 2018

Build PASSED

Started: 2018-03-07 12:03:09
Finished: 2018-03-07 12:18:22

View more information about this build on:

@gsnedders

This comment has been minimized.

Copy link
Contributor

gsnedders commented Mar 6, 2018

@jgraham can you drop the last commit and then we can land this?

@jgraham jgraham force-pushed the install_moz branch from 8d7787a to eb63a9f Mar 6, 2018

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Mar 7, 2018

I saw mozdownload failures on Travis, see #9852 (comment).

Will this PR fix it, or make it more likely to happen?

@jgraham

This comment has been minimized.

Copy link
Contributor Author

jgraham commented Mar 7, 2018

This will fix it.

@foolip

foolip approved these changes Mar 8, 2018

@jgraham jgraham merged commit 6a8a912 into master Mar 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gsnedders gsnedders deleted the install_moz branch Mar 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.