Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AccName: Correct "embedded-menu" expectations; add three new test cases #9880

Merged
merged 1 commit into from Mar 7, 2018

Conversation

Projects
None yet
5 participants
@joanmarie
Copy link
Contributor

joanmarie commented Mar 6, 2018

No description provided.

@wpt-pr-bot wpt-pr-bot added the accname label Mar 6, 2018

@wpt-pr-bot wpt-pr-bot requested a review from halindrome Mar 6, 2018

@joanmarie joanmarie self-assigned this Mar 6, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 6, 2018

Build PASSED

Started: 2018-03-06 16:37:02
Finished: 2018-03-06 16:42:33

View more information about this build on:

@Ms2ger

Ms2ger approved these changes Mar 7, 2018

@Ms2ger Ms2ger merged commit f30653c into web-platform-tests:master Mar 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@halindrome
Copy link
Contributor

halindrome left a comment

Question... there are a bunch of changes from "Flash the screen 1 times" to "Flash the screen times". Was that intentional? It seems weird.

@joanmarie

This comment has been minimized.

Copy link
Contributor Author

joanmarie commented Mar 7, 2018

They are intentional. That is the thing being corrected. Contrary to what was in the ARIA 1.0 test suite, the algorithm to calculate the name for embedded ARIA menus doesn't include using aria-selected as a means to include a value in the name. There are other tests where the 1 should be included.

The minutes don't adequately capture the discussion, but.... https://www.w3.org/2018/03/01-aria-minutes.html#item05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.