Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated filter-effects IDL file #9884

Conversation

@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 6, 2018

No description provided.

@wpt-pr-bot wpt-pr-bot requested review from jensl and yuki3 Mar 6, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 6, 2018

Build PASSED

Started: 2018-04-03 19:44:05
Finished: 2018-04-03 19:56:31

View more information about this build on:

@@ -0,0 +1,21 @@
interface SVGFETurbulenceElement : SVGElement {

This comment has been minimized.

Copy link
@foolip

foolip Mar 7, 2018

Contributor

https://drafts.fxtf.org/filter-effects/ has a cartload of IDL, so something gone awry here.

This comment has been minimized.

Copy link
@lukebjerring

lukebjerring Mar 7, 2018

Author Contributor

Yep, this was a bug in the FOAM model which I switched too. PTAL.

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-filter-effects branch 2 times, most recently from 5264160 to 545942e Mar 7, 2018

@foolip
Copy link
Contributor

foolip left a comment

This'll require a test in css/filter-effects/ using the file, and it might be a bit of work. Could skip creating instances to reduce the burden a bit, or find a tag name -> interface name mapping somewhere to stamp out instances more mechanically.

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-filter-effects branch from 545942e to d5e3000 Mar 28, 2018

@wpt-pr-bot wpt-pr-bot requested review from ayg, gsnedders and jgraham Mar 28, 2018

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-filter-effects branch from d5e3000 to d1f0f23 Mar 29, 2018

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-filter-effects branch from d1f0f23 to cc83fe8 Mar 29, 2018

@wpt-pr-bot wpt-pr-bot requested review from dirkschulze, grorg and svgeesus Mar 29, 2018

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Mar 29, 2018

Test added. PTAL.

@foolip

foolip approved these changes Mar 30, 2018

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Mar 30, 2018

Oh, there's a failing MISSING-LINK lint. @gsnedders, how to deal with that for .any.js tests?

@lukebjerring lukebjerring merged commit 2bbb6b4 into web-platform-tests:master Apr 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lukebjerring lukebjerring deleted the lukebjerring:idl-file-updates-filter-effects branch Apr 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.