Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate all IDL files into interfaces/ #9892

Merged
merged 1 commit into from Mar 8, 2018

Conversation

@foolip
Copy link
Contributor

foolip commented Mar 7, 2018

Closes #9026.

@foolip foolip requested a review from lukebjerring Mar 7, 2018

@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Mar 7, 2018

@lukebjerring, as an aside, this is another typical example where highlighting new test failures would be super helpful. If I've made a single typo here, some test might be broken entirely, and probably nobody would notice for a few weeks or months.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 7, 2018

Build PASSED

Started: 2018-03-07 04:49:44
Finished: 2018-03-07 05:03:00

Failing Jobs

  • MicrosoftEdge:16.16299

View more information about this build on:

@bsittler
Copy link
Contributor

bsittler left a comment

cookie-store parts look good to me

@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Mar 8, 2018

@jgraham can you rubber stamp? Or carefully review if you like :)

@wpt-pr-bot wpt-pr-bot requested a review from chunywang Mar 8, 2018

@bsittler
Copy link
Contributor

bsittler left a comment

Thanks, @foolip !

@bsittler bsittler merged commit 4a9668d into master Mar 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@foolip foolip deleted the idl-in-interfaces branch Mar 8, 2018

@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Mar 8, 2018

@lukebjerring, can you rebase all the branches that have merge conflicts now? Should see some nice new diffs.

@lukebjerring

This comment has been minimized.

Copy link
Contributor

lukebjerring commented Mar 8, 2018

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.