Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use interfaces/web-nfc.idl file #9893

Merged
merged 1 commit into from Mar 7, 2018

Conversation

Projects
None yet
4 participants
@Honry
Copy link
Contributor

Honry commented Mar 7, 2018

No description provided.

@wpt-pr-bot wpt-pr-bot added the web-nfc label Mar 7, 2018

@wpt-pr-bot wpt-pr-bot requested review from alexshalamov, kenchris and zolkis Mar 7, 2018

@Honry

This comment has been minimized.

Copy link
Contributor Author

Honry commented Mar 7, 2018

@lukebjerring, @foolip, it's a fixed in web-nfc/idlharness.https.html to reflect #9842, PTAL.

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Mar 7, 2018

Oh, sweet, thank you! Let's see how to combine these then...

@foolip foolip referenced this pull request Mar 7, 2018

Merged

Update the web-nfc IDL file #9842

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Mar 7, 2018

Must merged #9842, so the Travis jobs that are running are kind of pointless. @Honry, can you rebase this?

@foolip

foolip approved these changes Mar 7, 2018

Copy link
Contributor

foolip left a comment

Please go ahead and land once Travis jobs after rebasing haven't blown up. (Manually confirming that the tests still work would be nice too, if you can.)

@Honry

This comment has been minimized.

Copy link
Contributor Author

Honry commented Mar 7, 2018

@foolip, yes, I've confirmed manually.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 7, 2018

Build PASSED

Started: 2018-03-07 04:55:23
Finished: 2018-03-07 05:07:59

View more information about this build on:

@Honry Honry merged commit 98cb695 into web-platform-tests:master Mar 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Honry Honry deleted the Honry:use-nfc-idl branch Mar 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.