Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readable streams: test no throwing on redundant controller.error() #9896

Merged
merged 2 commits into from Mar 8, 2018

Conversation

Projects
None yet
4 participants
@domenic
Copy link
Member

domenic commented Mar 7, 2018

@domenic domenic requested a review from ricea Mar 7, 2018

@wpt-pr-bot wpt-pr-bot added the streams label Mar 7, 2018

@@ -325,7 +325,7 @@ promise_test(() => {
const closed = new ReadableStream({
start(c) {
c.close();
assert_throws(new TypeError(), () => c.error(), 'second call to error should throw a TypeError');
c.error();

This comment has been minimized.

Copy link
@ricea

ricea Mar 7, 2018

Contributor

Need to change the test description as well.

This comment has been minimized.

Copy link
@domenic

domenic Mar 7, 2018

Author Member

Fixed, thanks

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 7, 2018

Build PASSED

Started: 2018-03-07 09:23:23
Finished: 2018-03-07 09:38:04

View more information about this build on:

@ricea

ricea approved these changes Mar 7, 2018

Copy link
Contributor

ricea left a comment

lgtm

@domenic domenic merged commit efa3c75 into master Mar 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@domenic domenic deleted the no-throwing-rs-controller branch Mar 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.