Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix font paths after #9718 #9897

Merged
merged 1 commit into from Mar 15, 2018

Conversation

Projects
None yet
5 participants
@gsnedders
Copy link
Contributor

gsnedders commented Mar 7, 2018

I broke these in a fixup and didn't notice.

Fix font paths after #9718
My fixup broke these and I didn't notice, le sigh.

@gsnedders gsnedders requested a review from mrego Mar 7, 2018

@wpt-pr-bot wpt-pr-bot requested review from snuggs and yoavweiss Mar 7, 2018

@gsnedders

This comment has been minimized.

Copy link
Contributor Author

gsnedders commented Mar 7, 2018

Oh wait maybe there was a reason why preload had them separately, and that was caching? I remember @yoavweiss saying something about that ages ago?

@mrego

mrego approved these changes Mar 7, 2018

@mrego

This comment has been minimized.

Copy link
Member

mrego commented Mar 7, 2018

Oh wait maybe there was a reason why preload had them separately, and that was caching? I remember @yoavweiss saying something about that ages ago?

If we cannot have them in /fonts/ we need to copy CanvasTest.ttf and CanvasTest.ttf.sub.headers back to its folder.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 7, 2018

Build ERRORED

Started: 2018-03-15 16:11:43
Finished: 2018-03-15 16:31:20

Failing Jobs

  • firefox:nightly
  • safari:11.0

Unstable Results

Browser: "Firefox Nightly"

View in: WPT PR Status | TravisCI

Test Subtest Results Messages
/preload/download-resources.html   OK: 10
  Makes sure that preloaded resources are downloaded PASS: 8
FAIL: 2
assert_equals: resources/foo.vtt expected 1 but got 0
assert_equals: resources/white.mp4 expected 1 but got 0
/preload/onload-event.html   OK: 10
  Makes sure that preloaded resources trigger the onload event PASS: 7
FAIL: 3
assert_true: style triggered load event expected true got false
/preload/single-download-preload.html   OK: 10
  Makes sure that preloaded resources are not downloaded again when used PASS: 7
FAIL: 3
assert_equals: resources/square.png?single-download-preload expected 1 but got 2
assert_equals: resources/dummy.js?single-download-preload expected 1 but got 2

Browser: "Safari 11.0" (failures allowed)

View in: WPT PR Status | TravisCI

Test Subtest Results Messages
/preload/preload-with-type.html   TIMEOUT: 1
OK: 9
  Makes sure that preloaded resources with a type attribute trigger the onload event FAIL: 9
assert_true: Preload not supported expected true got false
@gsnedders

This comment has been minimized.

Copy link
Contributor Author

gsnedders commented Mar 8, 2018

@jgraham I can't reproduce any flakiness locally, either on this branch or before #9718.

@jgraham

This comment has been minimized.

Copy link
Contributor

jgraham commented Mar 15, 2018

This seems to reliably pass locally for me as well. I guess we'll find out if this actually did cause a problem.

@gsnedders gsnedders merged commit d56bf78 into web-platform-tests:master Mar 15, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@gsnedders gsnedders deleted the gsnedders:move-fonts-fixup branch Mar 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.