Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use force flag on git add operations during syncing #9901

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@jdm
Copy link
Contributor

jdm commented Mar 7, 2018

This ensures that files that belong in the tree but match .gitignore filters are still synced appropriately (like payment-handler/manifest.json, which matches MANIFEST.json).


This change is Reviewable

Use force flag on git add operations during syncing.
This ensures that files that belong in the tree but match .gitignore filters are still synced appropriately (like payment-handler/manifest.json, which matches MANIFEST.json).

@wpt-pr-bot wpt-pr-bot added the infra label Mar 7, 2018

@wpt-pr-bot wpt-pr-bot requested review from gsnedders and jgraham Mar 7, 2018

@jgraham

This comment has been minimized.

Copy link
Contributor

jgraham commented Mar 7, 2018

I am worried about this leading to cache files (.pyc, foo~ and so on) ending up in the tree. I think a better solution would be to special case the relevant files using .gitignore rules like
!payment-handlers/manifest.json
and a lint that uses git check-ignore to check that there aren't comitted files that match the ignore rule (this would probably have to be skipped in environments without git installed).

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 7, 2018

Build PASSED

Started: 2018-03-07 16:56:58
Finished: 2018-03-07 17:16:56

View more information about this build on:

@jdm

This comment has been minimized.

Copy link
Contributor Author

jdm commented Mar 7, 2018

This is superseded by #9902.

@jdm jdm closed this Mar 7, 2018

@sideshowbarker sideshowbarker deleted the jdm-patch-3 branch Nov 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.