Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update css-masking IDL file #9905

Merged

Conversation

@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 7, 2018

No description provided.

@wpt-pr-bot wpt-pr-bot requested review from jensl and yuki3 Mar 7, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 7, 2018

Build PASSED

Started: 2018-03-07 23:43:12
Finished: 2018-03-07 23:54:26

View more information about this build on:

Luke Bjerring

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-css-masking branch from 4af4e33 to 3b49989 Mar 7, 2018

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Mar 21, 2018

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Jun 4, 2018

@lukebjerring FYI, this is still missing a test.

lukebjerring added some commits Jun 5, 2018

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Jun 6, 2018

Test added. Test is poorly written since the deps on svg IDL can't be satisfied. Will have to follow up once SVGElement is somewhere in the interfaces folder.

@foolip

foolip approved these changes Jun 8, 2018

Copy link
Contributor

foolip left a comment

Nice, test entirely passing in Firefox, and reveals some minor broken thing in Chrome!

@foolip foolip merged commit 82a7c89 into web-platform-tests:master Jun 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lukebjerring lukebjerring deleted the lukebjerring:idl-file-updates-css-masking branch Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.