Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Update web-animations IDL file #9908
Hi, sorry for the lack of context - we (@foolip, @mdittmer and I) are working on a pipeline which automatically scrapes known WebIDL sources/specs and updates the IDL in the interfaces whenever it changes.
This PR is the output of running the scraper as a one-off, for which I've included updating the existing/equivalent IDL snippets that are inlined in the tests, to instead reference the generated (singular) interfaces/web-animations.idl file.
Later, we'll use OWNERS to automatically ping relevant persons when the source changed and the scraped IDL differs from what's in WPT.
Also, one question about the
Often I'll make spec, test, and code changes simultaneously, update the tests/code in Gecko, then upstream the tests to wpt. Can I rerun the scraper locally so that I can land the updated tests along with the code in Gecko?
NB: If you copy-paste from the source, strip leading whitespace, single blank line between snippets, your output will exactly match anyway. The comment is targeted at those who are unfamiliar with the spec, so as not to move the file.
Desired / future answer: Yes
When the tool matures (it still has a few edge-cases with whitespace, URLs, etc) we'll standardize how it gets run, document it, and ensure that changes can be included with test updates.