Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-grid] Minimum width items should include margins for indefinite grid containers #9921

Merged
merged 1 commit into from Mar 14, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 8, 2018

We had a TODO in IndefiniteSizeStrategy::MinLogicalWidthForChild()
that was always using 0 as margin of the item.
The patch just changes that for a call
to GridLayoutUtils::MarginLogicalWidthForChild()
(like we do in the DefiniteSizeStrategy version).

BUG=816762
TEST=external/wpt/css/css-grid/grid-items/grid-items-minimum-width-001.html
TEST=external/wpt/css/css-grid/grid-items/grid-items-minimum-width-002.html

Change-Id: I743584aff234625f2d00327c711c0577ffeab457
Reviewed-on: https://chromium-review.googlesource.com/955062
Commit-Queue: Manuel Rego Casasnovas rego@igalia.com
Reviewed-by: Javier Fernandez jfernandez@igalia.com
Cr-Commit-Position: refs/heads/master@{#543046}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 8, 2018

Build PASSED

Started: 2018-03-14 10:58:07
Finished: 2018-03-14 11:02:29

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-955062 branch 2 times, most recently from bb4977a to 44bc9bd Mar 14, 2018

[css-grid] Minimum width items should include margins for indefinite …
…grid containers

We had a TODO in IndefiniteSizeStrategy::MinLogicalWidthForChild()
that was always using 0 as margin of the item.
The patch just changes that for a call
to GridLayoutUtils::MarginLogicalWidthForChild()
(like we do in the DefiniteSizeStrategy version).

BUG=816762
TEST=external/wpt/css/css-grid/grid-items/grid-items-minimum-width-001.html
TEST=external/wpt/css/css-grid/grid-items/grid-items-minimum-width-002.html

Change-Id: I743584aff234625f2d00327c711c0577ffeab457
Reviewed-on: https://chromium-review.googlesource.com/955062
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#543046}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-955062 branch from 44bc9bd to 6bcdf45 Mar 14, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 19fb3d6 into master Mar 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-955062 branch Mar 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.