Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ServiceWorker] Fix an incorrect usage of assert_equals() in wpt test #9922

Merged
merged 1 commit into from Mar 9, 2018

Conversation

Projects
None yet
5 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 8, 2018

This prototype is 'assert_equals(actual, expected, description)', we
should pass 'actual' and 'expected' in order, to make the failure
message be reasonable.

This CL just fixes
external/wpt/service-workers/service-worker/navigate-window.https.html.

BUG=

Change-Id: Ic11ec67f27f7a9a5ae289ddda4362af72b4737d4
Reviewed-on: https://chromium-review.googlesource.com/955282
Commit-Queue: Han Leon leon.han@intel.com
Reviewed-by: Makoto Shimazu shimazu@chromium.org
Cr-Commit-Position: refs/heads/master@{#542048}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 8, 2018

Build PASSED

Started: 2018-03-09 06:21:09
Finished: 2018-03-09 06:29:02

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-955282 branch from cda559f to 242a939 Mar 9, 2018

[ServiceWorker] Fix an incorrect usage of assert_equals() in wpt test
This prototype is 'assert_equals(actual, expected, description)', we
should pass 'actual' and 'expected' in order, to make the failure
message be reasonable.

This CL just fixes
external/wpt/service-workers/service-worker/navigate-window.https.html.

BUG=

Change-Id: Ic11ec67f27f7a9a5ae289ddda4362af72b4737d4
Reviewed-on: https://chromium-review.googlesource.com/955282
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542048}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-955282 branch from 242a939 to c33ec06 Mar 9, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 0de8b99 into master Mar 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-955282 branch Mar 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.