Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes lines containing `GLib-GObject-CRITICAL` from the logs #9924

Merged
merged 4 commits into from Mar 12, 2018

Conversation

Projects
None yet
6 participants
@kritisingh1
Copy link
Member

kritisingh1 commented Mar 8, 2018

Closes #9657


This change is Reviewable

@wpt-pr-bot wpt-pr-bot added the infra label Mar 8, 2018

@wpt-pr-bot wpt-pr-bot requested review from gsnedders and jgraham Mar 8, 2018

@kritisingh1 kritisingh1 force-pushed the kritisingh1:GObject branch from 8a3e2cb to 83d7a2c Mar 8, 2018

@jgraham
Copy link
Contributor

jgraham left a comment

I think this generally looks good, but let's make the small fixup.

data,
command=" ".join(self.runner.command))
if "GLib-GObject-CRITICAL" in line:
line = "";

This comment has been minimized.

Copy link
@jgraham

jgraham Mar 8, 2018

Contributor

I think just return should be sufficient.

@kritisingh1 kritisingh1 force-pushed the kritisingh1:GObject branch from 83d7a2c to 8523f0a Mar 8, 2018

@kritisingh1

This comment has been minimized.

Copy link
Member Author

kritisingh1 commented Mar 8, 2018

@jgraham I have updated the PR. Please review. Thanks

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 8, 2018

Build PASSED

Started: 2018-03-12 20:47:13
Finished: 2018-03-12 21:01:36

View more information about this build on:

command=" ".join(self.runner.command))
if "GLib-GObject-CRITICAL" in line:
return
if(line):

This comment has been minimized.

Copy link
@gsnedders

gsnedders Mar 12, 2018

Contributor

Tiny nit: this should be if line:. Otherwise, this looks good to me. (But I'd still like @jgraham to check.)

@jgraham jgraham merged commit 284dfe4 into web-platform-tests:master Mar 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Mar 13, 2018

Yay, finally less verbose, thank you @kritisingh1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.