Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent spawning WebSocketDaemon when ws_doc_root is null #9929

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@kritisingh1
Copy link
Member

kritisingh1 commented Mar 8, 2018

Closes #8675


This change is Reviewable

@wpt-pr-bot wpt-pr-bot added the infra label Mar 8, 2018

@wpt-pr-bot wpt-pr-bot requested review from gsnedders and jgraham Mar 8, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 8, 2018

Build PASSED

Started: 2018-03-25 14:37:51
Finished: 2018-03-25 14:52:16

View more information about this build on:

@kritisingh1

This comment has been minimized.

Copy link
Member Author

kritisingh1 commented Mar 8, 2018

@jgraham Please review and let me know further changes. Thank you :)

@@ -610,6 +610,9 @@ def stop(self):

def start_ws_server(host, port, paths, routes, bind_hostname, config, ssl_config,
**kwargs):
if ws_doc_root is None:

This comment has been minimized.

Copy link
@gsnedders

gsnedders Mar 12, 2018

Contributor
./serve/serve.py:613:8: F821 undefined name 'ws_doc_root'

Where is ws_doc_root meant to come from? Is this meant to be the paths["ws_doc_root"] from below?

@kritisingh1 kritisingh1 force-pushed the kritisingh1:WebSocketDaemon branch from 967de92 to e796d8e Mar 25, 2018

@kritisingh1

This comment has been minimized.

Copy link
Member Author

kritisingh1 commented Mar 25, 2018

@gsnedders I have updated the PR. Please review. Thanks

@kritisingh1

This comment has been minimized.

Copy link
Member Author

kritisingh1 commented Apr 2, 2018

@gsnedders @jgraham is anything else needed to solve the issue? Please look into it and tell me if any. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.