Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed tests g,h,q,r from cascade-import-002.xht #9930

Merged
merged 4 commits into from Mar 8, 2018

Conversation

Projects
None yet
4 participants
@kritisingh1
Copy link
Member

kritisingh1 commented Mar 8, 2018

Closes #9910

@dbaron
Copy link
Member

dbaron left a comment

Shouldn't there be a change somewhere that removes the actual <meta http-equiv=link> and presumably the style sheet that it links to?

@@ -65,10 +61,6 @@
f Rule
<meta http-equiv="Link">

This comment has been minimized.

Copy link
@dbaron

dbaron Mar 8, 2018

Member

This looks more like the comments are associated with the letters after them rather than the letters before them.

@dbaron
Copy link
Member

dbaron left a comment

You still need to remove the actual <meta http-equiv="Link"> elements and the style sheets that they reference.

@kritisingh1

This comment has been minimized.

Copy link
Member Author

kritisingh1 commented Mar 8, 2018

@dbaron updated the PR. Please review. Thanks

@dbaron

This comment has been minimized.

Copy link
Member

dbaron commented Mar 8, 2018

Almost there, but you also need to remove the imported stylesheets 002g and 002q.

@dbaron

dbaron approved these changes Mar 8, 2018

@dbaron

This comment has been minimized.

Copy link
Member

dbaron commented Mar 8, 2018

(Once the Travis CI build finishes, I'll hit the "Squash and merge" button.)

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 8, 2018

Build PASSED

Started: 2018-03-08 22:21:57
Finished: 2018-03-08 22:30:31

View more information about this build on:

@dbaron dbaron merged commit df0b73b into web-platform-tests:master Mar 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dbaron

This comment has been minimized.

Copy link
Member

dbaron commented Mar 8, 2018

Merged. Thanks for the fix.

Note that I rewrote the commit message a little bit so that it makes more sense in the context of a commit log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.