Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-writing-mode] Move sideways-* tests to L4> #9938

Merged

Conversation

Projects
None yet
4 participants
@fantasai
Copy link
Contributor

fantasai commented Mar 9, 2018

No description provided.

@kojiishi
Copy link
Contributor

kojiishi left a comment

Looks great, except one probably a typo, once it's fixed, this is good to land.

@@ -14,7 +14,7 @@
{
color: orange;
font: 60px/1 Ahem; /* computes to 60px/60px */
writing-mode: vertical-lr;
xwriting-mode: vertical-lr;

This comment has been minimized.

Copy link
@kojiishi

kojiishi Mar 9, 2018

Contributor

Is this typo?

This comment has been minimized.

Copy link
@fantasai

fantasai Mar 9, 2018

Author Contributor

Yes :(

@fantasai fantasai force-pushed the fantasai:sideways-writing-mode-4 branch from 4bcb67d to 6519c5f Mar 9, 2018

@fantasai
Copy link
Contributor Author

fantasai left a comment

Fixed, thanks!

@@ -14,7 +14,7 @@
{
color: orange;
font: 60px/1 Ahem; /* computes to 60px/60px */
writing-mode: vertical-lr;
xwriting-mode: vertical-lr;

This comment has been minimized.

Copy link
@fantasai

fantasai Mar 9, 2018

Author Contributor

Yes :(

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 9, 2018

Build PASSED

Started: 2018-03-09 07:23:44
Finished: 2018-03-09 07:37:08

Failing Jobs

  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@fantasai fantasai merged commit 6911cb3 into web-platform-tests:master Mar 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@fantasai fantasai deleted the fantasai:sideways-writing-mode-4 branch Mar 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.