Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idl: Fix [EnforceRange] annotations #9939

Merged
merged 1 commit into from Mar 10, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 9, 2018

This CL fixes usages of [EnforceRange] annotations in IDL files.
No changes on behaviors.

CSSUnitValue:
[EnforceRange] can't annotate non-integer numbers, and the spec
doesn't have the annotation.

OffscreenCanvas:
The spec doesn't have [EnforceRange], but it seems the spec is wrong.
(requesting to update the spec; whatwg/html#3540)

IDBFactory and IDBIndex:
Follows spec.

Test IDLs:
This CL works for tests in Chromium repository, and following tests
need to be upstream for WPT.

  • wpt/interfaces/IndexedDB.idl
  • wpt/interfaces/WebCryptoAPI.idl

Bug: 819112
Change-Id: If7082cba0251a83e269fea428340b3b61d4c17cf
Reviewed-on: https://chromium-review.googlesource.com/952589
Reviewed-by: Yuki Shiino yukishiino@chromium.org
Reviewed-by: Kent Tamura tkent@chromium.org
Reviewed-by: Kentaro Hara haraken@chromium.org
Commit-Queue: Hitoshi Yoshida peria@chromium.org
Cr-Commit-Position: refs/heads/master@{#542375}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 9, 2018

Build PASSED

Started: 2018-03-10 16:19:12
Finished: 2018-03-10 16:24:07

View more information about this build on:

idl: Fix [EnforceRange] annotations
This CL fixes usages of [EnforceRange] annotations in IDL files.
No changes on behaviors.

CSSUnitValue:
 [EnforceRange] can't annotate non-integer numbers, and the spec
 doesn't have the annotation.

OffscreenCanvas:
 The spec doesn't have [EnforceRange], but it seems the spec is wrong.
 (requesting to update the spec; whatwg/html#3540)

IDBFactory and IDBIndex:
 Follows spec.

Test IDLs:
 This CL works for tests in Chromium repository, and following tests
 need to be upstream for WPT.
 - wpt/interfaces/IndexedDB.idl
 - wpt/interfaces/WebCryptoAPI.idl

Bug: 819112
Change-Id: If7082cba0251a83e269fea428340b3b61d4c17cf
Reviewed-on: https://chromium-review.googlesource.com/952589
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542375}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-952589 branch from 4757cb0 to 079e772 Mar 10, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit b0a57a6 into master Mar 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-952589 branch Mar 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.