Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "short" harness timeout value #9959

Conversation

Projects
None yet
4 participants
@AnthumChris
Copy link
Member

AnthumChris commented Mar 10, 2018

This would allow tests that explicitly call window.stop() to exit after 2s instead of waiting the full 10s to timeout by adding <meta name="timeout" content="short">. For example, the "short" value could be applied to the tests below:


This change is Reviewable

@wpt-pr-bot wpt-pr-bot added the infra label Mar 10, 2018

@wpt-pr-bot wpt-pr-bot requested review from ayg, gsnedders and jgraham Mar 10, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 10, 2018

Build PASSED

Started: 2018-03-10 18:46:18
Finished: 2018-03-10 18:52:18

View more information about this build on:

@jgraham

This comment has been minimized.

Copy link
Contributor

jgraham commented Mar 12, 2018

I'm a bit skeptical of this. I don't think we have any way to know that a test "ought" to time out, so this seems like a workaround for one visible effect of a deeper issue.

@AnthumChris

This comment has been minimized.

Copy link
Member Author

AnthumChris commented Mar 12, 2018

Yes, I see your point. After more experimentation, explicitly calling window.dispatchEvent(new Event('load')) would resume the natural flow of things after calling window.stop(), and test_harness would complete and avoid the timeout.

That's probably a better solution and I'm happy canceling this PR

@AnthumChris AnthumChris deleted the AnthumChris:short-harness-timeout-option branch Mar 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.