Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace assert_own_property with assert_idl_attribute #9960

Merged
merged 1 commit into from Mar 14, 2018

Conversation

Projects
None yet
4 participants
@csnardi
Copy link
Member

csnardi commented Mar 10, 2018

CSSOM objects do not implement attributes as their own properties; they are IDL attributes. Switch to use assert_idl_attribute instead of assert_own_property. Also make inline-style-001.html pass by removing assert_readonly (it resets the attribute, making future tests fail) and use assert_equals instead of assert_regexp_match.

Fixes #6203.

Replace assert_own_property with assert_idl_attribute
CSSOM objects do not implement attributes as their own properties; they are IDL attributes. Switch to use assert_idl_attribute instead of assert_own_property. Also make inline-style-001.html pass by removing assert_readonly (it resets the attribute, making future tests fail) and use assert_equals instead of assert_regexp_match.
@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 10, 2018

Build PASSED

Started: 2018-03-10 19:25:28
Finished: 2018-03-10 19:33:21

View more information about this build on:

@dbaron

dbaron approved these changes Mar 14, 2018

Copy link
Member

dbaron left a comment

@dbaron dbaron merged commit 8896c5c into web-platform-tests:master Mar 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@csnardi csnardi deleted the csnardi:cssom-own-property branch Mar 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.