Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[presentation-api] check if a URL with an unsupported scheme is ignored #9966

Conversation

Projects
None yet
5 participants
@tomoyukilabs
Copy link
Contributor

tomoyukilabs commented Mar 12, 2018

This PR is based on the suggested change on Presentation API, addressed by w3c/presentation-api#447. In detail, the following tests are added:

  • To check if an instance of PresentationRequest with URLs including one with an unsupported scheme is successfully constructed
  • To check if NotSupportedError is thrown when only single or multiple URLs with unsupported schemes are specified
@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 12, 2018

Build PASSED

Started: 2018-03-12 10:19:39
Finished: 2018-03-12 10:27:32

View more information about this build on:

@tidoust
Copy link
Contributor

tidoust left a comment

Review somewhat slipped through the cracks... but that seems good, thks @tomoyukilabs !

@tidoust tidoust merged commit 1cbb928 into web-platform-tests:master Mar 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mfoltzgoogle

This comment has been minimized.

Copy link
Contributor

mfoltzgoogle commented Mar 26, 2018

LGTM, thank you @tomoyukilabs !

@tomoyukilabs tomoyukilabs deleted the tomoyukilabs:presentation-api-unsupported-scheme branch Jun 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.