Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDL update for AbstractRange and StaticRange #9967

Merged
merged 2 commits into from Mar 16, 2018

Conversation

Projects
None yet
4 participants
@annevk
Copy link
Member

annevk commented Mar 12, 2018

@wpt-pr-bot wpt-pr-bot requested review from jensl and yuki3 Mar 12, 2018

@wpt-pr-bot wpt-pr-bot requested review from garykac and siusin Mar 12, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 12, 2018

Build PASSED

Started: 2018-03-12 11:13:39
Finished: 2018-03-12 11:42:59

Failing Jobs

  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@annevk annevk merged commit 359dac1 into master Mar 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@annevk annevk deleted the annevk/staticrange branch Mar 16, 2018

annevk added a commit to whatwg/dom that referenced this pull request Mar 16, 2018

Add AbstractRange and StaticRange
This refactors large parts of the DOM Standard to reclassify Range
objects as "live ranges" rather than "ranges". The bits shared
between StaticRange and Range objects are put on a shared superclass
named AbstractRange.

This also introduces a "collapsed" definition and uses it throughout.

It does not contain everything from
https://w3c.github.io/staticrange/. I based this draft on the IDL
present in implementations, coupled with the desire for a superclass.
Extensions beyond this seem best addressed as follow-ups.

Tests: web-platform-tests/wpt#9967.

See also w3c/staticrange#1.

aarongable pushed a commit to chromium/chromium that referenced this pull request May 2, 2018

Remove orphaned staticrange/OWNERS
Only test was removed in web-platform-tests/wpt#9967.

No-Try: true
Change-Id: I9cb46906d621d25261476f5de414622f694d4173
Reviewed-on: https://chromium-review.googlesource.com/1039191
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Commit-Queue: Gary Kacmarcik <garykac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555412}

@choniong choniong referenced this pull request May 29, 2018

Closed

Add staticrange/OWNERS #11205

@lukebjerring lukebjerring referenced this pull request May 30, 2018

Closed

Revert #9887 #11250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.