Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup gitignore #9981

Merged
merged 5 commits into from Mar 13, 2018

Conversation

Projects
None yet
4 participants
@gsnedders
Copy link
Contributor

gsnedders commented Mar 12, 2018

This change is Reviewable

@gsnedders gsnedders requested a review from jgraham Mar 12, 2018

@wpt-pr-bot wpt-pr-bot added the infra label Mar 12, 2018

_certs
config.json

# Various OS/editor specific files

This comment has been minimized.

Copy link
@gsnedders

gsnedders Mar 12, 2018

Author Contributor

Do we want to add a comment about some vague policy about adding stuff here? I mean, I'm assuming we don't just want to add everything from https://github.com/github/gitignore/tree/master/Global into here.

This comment has been minimized.

Copy link
@jgraham

jgraham Mar 12, 2018

Contributor

"emacs is the one true editor" seems like a good policy to me :p

I expect it's not worth thinking too hard about this and we should just let the section grow in an ad-hoc way.

_certs
.virtualenv
config.json
node_modules
scratch

This comment has been minimized.

Copy link
@gsnedders

gsnedders Mar 12, 2018

Author Contributor

What even is this? Should this be in the previous section?

This comment has been minimized.

Copy link
@jgraham

jgraham Mar 12, 2018

Contributor

No idea

This comment has been minimized.

Copy link
@gsnedders

gsnedders Mar 13, 2018

Author Contributor

Seems to be from 8267f07, added along with node. But Google suggests it isn't node, so who knows.

.gitignore Outdated
webdriver/.idea
.vscode/
.DS_Store
*.rej
_venv
webdriver/.cache

This comment has been minimized.

Copy link
@gsnedders

gsnedders Mar 12, 2018

Author Contributor

What even is this? Should this be in the previous section?

This comment has been minimized.

Copy link
@jgraham

jgraham Mar 12, 2018

Contributor

pytest junk

This comment has been minimized.

Copy link
@gsnedders

gsnedders Mar 12, 2018

Author Contributor

oh is this where .pytest_cache comes from? that, but renamed?

This comment has been minimized.

Copy link
@jgraham

jgraham Mar 13, 2018

Contributor

Yeah it seems that the name changed at some point, so maybe this rule should be updated.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 12, 2018

Build PASSED

Started: 2018-03-13 13:42:29
Finished: 2018-03-13 13:45:56

View more information about this build on:

.gitignore Outdated
webdriver/.idea
.vscode/
.DS_Store
*.rej
_venv
webdriver/.cache

This comment has been minimized.

Copy link
@jgraham

jgraham Mar 12, 2018

Contributor

pytest junk

.gitignore Outdated
scratch
testharness_runner.html
webdriver/.idea

This comment has been minimized.

Copy link
@jgraham

jgraham Mar 12, 2018

Contributor

I imagine this should be matched anywhere?

_certs
.virtualenv
config.json
node_modules
scratch

This comment has been minimized.

Copy link
@jgraham

jgraham Mar 12, 2018

Contributor

No idea

_certs
config.json

# Various OS/editor specific files

This comment has been minimized.

Copy link
@jgraham

jgraham Mar 12, 2018

Contributor

"emacs is the one true editor" seems like a good policy to me :p

I expect it's not worth thinking too hard about this and we should just let the section grow in an ad-hoc way.

@gsnedders gsnedders force-pushed the gsnedders:gitignore-cleanup branch from 876aef2 to 8efcb04 Mar 13, 2018

@gsnedders

This comment has been minimized.

Copy link
Contributor Author

gsnedders commented Mar 13, 2018

@jgraham plz merge if this still looks good to you once CI passes

@jgraham jgraham merged commit 970fca8 into web-platform-tests:master Mar 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gsnedders gsnedders deleted the gsnedders:gitignore-cleanup branch Mar 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.