Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct order of serialized media list values #9985

Merged

Conversation

Projects
None yet
4 participants
@csnardi
Copy link
Member

csnardi commented Mar 13, 2018

According to the spec (https://drafts.csswg.org/cssom/#serialize-a-media-query-list), each media query should be serialized in the same order as they appear in the media query list. Media features are sorted in lexicographical order in a single media query, but media queries are not sorted in the same manner. Fix two tests to reflect the spec.

Correct order of serialized media list values
According to the spec (https://drafts.csswg.org/cssom/#serialize-a-media-query-list), each media query should be serialized in the same order as they appear in the media query list. Media *features* are sorted in lexicographical order in a single media query, but media queries are not sorted in the same manner. Fix two tests to reflect the spec.
@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 13, 2018

Build PASSED

Started: 2018-03-13 01:41:35
Finished: 2018-03-13 01:50:45

View more information about this build on:

@dbaron

dbaron approved these changes Mar 13, 2018

@dbaron dbaron merged commit 682f0a2 into web-platform-tests:master Mar 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@csnardi csnardi deleted the csnardi:cssom-medialist-serialization branch Mar 13, 2018

@csnardi

This comment has been minimized.

Copy link
Member Author

csnardi commented Mar 13, 2018

@dbaron If you have a second to review, I submitted two other quick CSSOM PRs (#9958 and #9960).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.