Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure cloneNode() does not preserve the prototype #9987

Merged
merged 1 commit into from Apr 16, 2018

Conversation

Projects
None yet
4 participants
@annevk
Copy link
Member

annevk commented Mar 13, 2018

Closes whatwg/dom#565.

It would be great to hear from @bigopon since I cannot reproduce this in Chrome. Given that I'm not sure it's worth adding, but it's probably a good "defense in depth" check.

@wpt-pr-bot wpt-pr-bot added the dom label Mar 13, 2018

@wpt-pr-bot wpt-pr-bot requested review from ayg, jdm and zqzhang Mar 13, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 13, 2018

Build PASSED

Started: 2018-03-13 04:39:26
Finished: 2018-03-13 04:47:25

View more information about this build on:

@annevk

This comment has been minimized.

Copy link
Member Author

annevk commented Apr 13, 2018

It can indeed not be reproduced in Chrome (anymore). I guess this is still worth adding.

@annevk annevk requested a review from foolip Apr 13, 2018

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Apr 15, 2018

It can indeed not be reproduced in Chrome (anymore)

I tried bisecting it using bisect-builds.py going back a year, points on master that became Chrome 60, but the test added here has been passing all along.

Whatever the original problem was, it seems like this test doesn't exercise it. It's not wrong, but also not very meaningful to test for IMHO. I'll review it and let @annevk make the call though.

@foolip

foolip approved these changes Apr 15, 2018

@foolip foolip referenced this pull request Apr 15, 2018

Closed

`cloneNode` should preserve element prototype #565

1 of 4 tasks complete

@annevk annevk merged commit 691673d into master Apr 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@annevk annevk deleted the annevk/do-not-clone-prototype branch Apr 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.