Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change PaymentRequest.abort() to manual test #9988

Merged
merged 2 commits into from Mar 13, 2018

Conversation

Projects
None yet
5 participants
@marcoscaceres
Copy link
Contributor

marcoscaceres commented Mar 13, 2018

Show now triggered by user activation: w3c/payment-request#655

@mnoorenberghe
Copy link
Contributor

mnoorenberghe left a comment

Hmm… any idea why git's move detection work here?

@marcoscaceres

This comment has been minimized.

Copy link
Contributor Author

marcoscaceres commented Mar 13, 2018

Not sure, tbh... I definitely did a git mv to move it... but then did a git commit -am which maybe confused it.

@marcoscaceres

This comment has been minimized.

Copy link
Contributor Author

marcoscaceres commented Mar 13, 2018

(not super worried about the move history, tbh)

@marcoscaceres marcoscaceres changed the title Change test to manual to match spec Change PaymentRequest.abort() to manual test Mar 13, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 13, 2018

Build PASSED

Started: 2018-03-13 05:09:20
Finished: 2018-03-13 05:18:04

View more information about this build on:

@marcoscaceres marcoscaceres merged commit 3c78e4a into master Mar 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@marcoscaceres marcoscaceres deleted the show_manual branch Mar 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.