show() must be triggered by user activation #9990
Conversation
marcoscaceres
commented
Mar 13, 2018
•
marcoscaceres
commented
- actual test for show() must be triggered by user activation w3c/payment-request#655
wpt-pr-bot
requested review from
domenic,
mnoorenberghe,
MSFTkihans and
rsolomakhin
| } | ||
| }, "Must be possible to construct a payment request"); | ||
|
|
||
| promise_test(async t => { |
There was a problem hiding this comment.
@domenic, I'm a bit unsure if using setTimeout to race these two promises is ok? Basically, a conforming implementation would return acceptPromise as rejected with a SecurityError. However, in a non-conforming browser, calling .show() will show the payment sheet, causing the test to get stuck waiting on acceptPromise to resolve.
In order to avoid the test getting stuck, I call .abort() after 100 milliseconds. Is there a better was of doing this?
There was a problem hiding this comment.
Generally we let tests timeout in non-conforming browsers. That way, their CI infrastructure can control the timeout period, instead of getting it hard-coded to 100 ms as here.
There was a problem hiding this comment.
Makes sense. I’ll split this into manual and automated test files. Then the automated can time out.
Build PASSEDStarted: 2018-03-14 00:49:56 View more information about this build on: |
