Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and cleanup wpt/css/css-text/ failures #9999

Merged
merged 1 commit into from Mar 14, 2018

Conversation

Projects
None yet
6 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 13, 2018

This patch reviewed failures of wpt/css/css-text, grouped and
sorted, with following modifications:

  1. Skip importing features with no active contributors.
    When we have plans or contributors, we can unskip them.

  2. Following tests were removed because they are based on
    old versions of Unicode. According to the most recent
    spec at:
    https://www.unicode.org/Public/UNIDATA/extracted/DerivedLineBreak.txt
    css3-text-line-break-opclns-013 U+23B4 is AL, not CL
    css3-text-line-break-opclns-048 U+FD3E is CL, not OP
    css3-text-line-break-opclns-118 U+23B5 is AL, not CL
    css3-text-line-break-opclns-154 U+FD3F is OP, not CL
    css3-text-line-break-opclns-216 U+30FC is CJ, not NS
    css3-text-line-break-opclns-224 U+FF70 is CJ, not NS

  3. Following tests were removed because they hard code pixel
    widths, and their cases are covered by other tests.
    word-break-normal-002

  4. Following tests were removed because they are based on JLREQ,
    a W3C notes that explains traditional Japanese typography, but
    not defined in the CSS spec nor in Unicode spec.
    line-break-normal-025
    line-break-strict-018a
    line-break-strict-018b

Bug: 817781, 817778, 817776
Change-Id: I92b1abc99fa8019e5d514e485f6c4733075216ba
Reviewed-on: https://chromium-review.googlesource.com/960683
Reviewed-by: Manuel Rego Casasnovas rego@igalia.com
Reviewed-by: Robert Ma robertma@chromium.org
Commit-Queue: Koji Ishii kojii@chromium.org
Cr-Commit-Position: refs/heads/master@{#543049}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 13, 2018

Build PASSED

Started: 2018-03-14 11:30:19
Finished: 2018-03-14 11:35:20

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-960683 branch from ab3b149 to 2d54f74 Mar 13, 2018

@Ms2ger

This comment has been minimized.

Copy link
Contributor

Ms2ger commented Mar 13, 2018

FYI @r12a

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-960683 branch from 2d54f74 to 5557914 Mar 13, 2018

Review and cleanup wpt/css/css-text/ failures
This patch reviewed failures of wpt/css/css-text, grouped and
sorted, with following modifications:

1. Skip importing features with no active contributors.
   When we have plans or contributors, we can unskip them.

2. Following tests were removed because they are based on
   old versions of Unicode. According to the most recent
   spec at:
https://www.unicode.org/Public/UNIDATA/extracted/DerivedLineBreak.txt
css3-text-line-break-opclns-013 U+23B4 is AL, not CL
css3-text-line-break-opclns-048 U+FD3E is CL, not OP
css3-text-line-break-opclns-118 U+23B5 is AL, not CL
css3-text-line-break-opclns-154 U+FD3F is OP, not CL
css3-text-line-break-opclns-216 U+30FC is CJ, not NS
css3-text-line-break-opclns-224 U+FF70 is CJ, not NS

3. Following tests were removed because they hard code pixel
   widths, and their cases are covered by other tests.
word-break-normal-002

4. Following tests were removed because they are based on JLREQ,
   a W3C notes that explains traditional Japanese typography, but
   not defined in the CSS spec nor in Unicode spec.
line-break-normal-025
line-break-strict-018a
line-break-strict-018b

Bug: 817781, 817778, 817776
Change-Id: I92b1abc99fa8019e5d514e485f6c4733075216ba
Reviewed-on: https://chromium-review.googlesource.com/960683
Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543049}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-960683 branch from 5557914 to 2c8de31 Mar 14, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 9cd6f7a into master Mar 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-960683 branch Mar 14, 2018

@r12a

This comment has been minimized.

Copy link
Contributor

r12a commented Mar 15, 2018

@Ms2ger thanks for the heads up.

fyi, I have just rewritten a bunch of related (jazh) tests to use scripted results rather than reftests, and updated to match Unicode 10. (https://w3c.github.io/i18n-tests/results/line-breaks-jazh). I'm just checking that everything seems ok, and then i should replace the 500-odd jazh tests on WPT. At that point, i expect to rewrite these tests too in a similar way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.