New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match IETF draft Authorization header #200

Closed
benlast opened this Issue Aug 10, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@benlast

benlast commented Aug 10, 2016

The Authorization header produced by this library includes Bearer as the scheme. The spec at https://tools.ietf.org/html/draft-ietf-webpush-vapid-01 states that the scheme should be WebPush (https://tools.ietf.org/html/draft-ietf-webpush-vapid-01#section-3).

@marco-c

This comment has been minimized.

Show comment
Hide comment
@marco-c

marco-c Aug 11, 2016

Member

I think FCM doesn't support this yet, but still requires Bearer.

Thank you for opening the issue, I never would have noticed the change.

Member

marco-c commented Aug 11, 2016

I think FCM doesn't support this yet, but still requires Bearer.

Thank you for opening the issue, I never would have noticed the change.

@gauntface

This comment has been minimized.

Show comment
Hide comment
@gauntface

gauntface Aug 11, 2016

Collaborator

Will follow up on this tomorrow, thanks for the bug.

Does this currently break any browsers if we switch to this?

Collaborator

gauntface commented Aug 11, 2016

Will follow up on this tomorrow, thanks for the bug.

Does this currently break any browsers if we switch to this?

@marco-c

This comment has been minimized.

Show comment
Hide comment
@marco-c

marco-c Aug 11, 2016

Member

Does this currently break any browsers if we switch to this?

I've just tried to run the tests after the change, they're failing with Chrome, working with Firefox.

Member

marco-c commented Aug 11, 2016

Does this currently break any browsers if we switch to this?

I've just tried to run the tests after the change, they're failing with Chrome, working with Firefox.

@gauntface

This comment has been minimized.

Show comment
Hide comment
@gauntface

gauntface Aug 11, 2016

Collaborator

Schweet thank you for the info

On Wed, 10 Aug 2016, 17:58 Marco, notifications@github.com wrote:

Does this currently break any browsers if we switch to this?

I've just tried to run the tests after the change, they're failing with
Chrome, working with Firefox.


You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#200 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIh8Jpr5favSVU33c1gB7VgacGvN-5yks5qenOzgaJpZM4JhixR
.

Collaborator

gauntface commented Aug 11, 2016

Schweet thank you for the info

On Wed, 10 Aug 2016, 17:58 Marco, notifications@github.com wrote:

Does this currently break any browsers if we switch to this?

I've just tried to run the tests after the change, they're failing with
Chrome, working with Firefox.


You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#200 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIh8Jpr5favSVU33c1gB7VgacGvN-5yks5qenOzgaJpZM4JhixR
.

This was referenced Sep 17, 2016

@marco-c marco-c closed this Sep 20, 2016

@gauntface gauntface referenced this issue Sep 27, 2016

Closed

Enr1 #3438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment