From bd379d29f3104449ceb9497f5372e5caf8d22343 Mon Sep 17 00:00:00 2001 From: Josh Justice Date: Sat, 6 Nov 2021 08:24:23 -0400 Subject: [PATCH 1/3] feat: add a11y labels to buttons --- src/Date/CalendarHeader.tsx | 2 ++ src/Date/DatePickerModalContentHeader.tsx | 3 +++ src/Date/DatePickerModalHeader.tsx | 1 + 3 files changed, 6 insertions(+) diff --git a/src/Date/CalendarHeader.tsx b/src/Date/CalendarHeader.tsx index 2cc4e174..4ab69db7 100644 --- a/src/Date/CalendarHeader.tsx +++ b/src/Date/CalendarHeader.tsx @@ -48,6 +48,7 @@ function CalendarHeader({ > Date: Sat, 6 Nov 2021 08:36:18 -0400 Subject: [PATCH 2/3] feat: make more buttons accessible --- src/Date/Day.tsx | 1 + src/Date/Month.tsx | 2 ++ src/Date/YearPicker.tsx | 2 ++ 3 files changed, 5 insertions(+) diff --git a/src/Date/Day.tsx b/src/Date/Day.tsx index 54b863bf..5dba7596 100644 --- a/src/Date/Day.tsx +++ b/src/Date/Day.tsx @@ -73,6 +73,7 @@ function Day(props: { styles.button, { backgroundColor: inRange ? selectColor : undefined }, ]} + accessibilityRole="button" // RN types bug hasTVPreferredFocus={undefined} tvParallaxProperties={undefined} diff --git a/src/Date/Month.tsx b/src/Date/Month.tsx index 8472c105..a465f4ca 100644 --- a/src/Date/Month.tsx +++ b/src/Date/Month.tsx @@ -260,6 +260,8 @@ function Month(props: MonthSingleProps | MonthRangeProps | MonthMultiProps) { onPressYear(year) : undefined} + accessibilityRole="button" + accessibilityLabel={`${monthName} ${year}`} style={[ styles.yearButton, { diff --git a/src/Date/YearPicker.tsx b/src/Date/YearPicker.tsx index 55790b82..1f8cbe38 100644 --- a/src/Date/YearPicker.tsx +++ b/src/Date/YearPicker.tsx @@ -74,6 +74,8 @@ function YearPure({ onPressYear(year)} + accessibilityRole="button" + accessibilityLabel={String(year)} style={styles.yearButton} // RN types bug hasTVPreferredFocus={undefined} From 3e6cc669386938b8426450d5a98b68d27b8b0787 Mon Sep 17 00:00:00 2001 From: Josh Justice Date: Wed, 10 Nov 2021 06:59:41 -0500 Subject: [PATCH 3/3] feat: internationalize new copy --- src/Date/CalendarHeader.tsx | 5 +++-- src/Date/DatePickerModalContentHeader.tsx | 4 +++- src/Date/DatePickerModalHeader.tsx | 2 +- src/translations/en.ts | 5 +++++ src/translations/enGB.ts | 5 +++++ src/translations/utils.ts | 5 +++++ 6 files changed, 22 insertions(+), 4 deletions(-) diff --git a/src/Date/CalendarHeader.tsx b/src/Date/CalendarHeader.tsx index 4ab69db7..f27fcbad 100644 --- a/src/Date/CalendarHeader.tsx +++ b/src/Date/CalendarHeader.tsx @@ -3,6 +3,7 @@ import { StyleSheet, View } from 'react-native' import { IconButton, useTheme } from 'react-native-paper' import DayNames, { dayNamesHeight } from './DayNames' import type { DisableWeekDaysType } from './dateUtils' +import { getTranslation } from '../translations/utils' const buttonContainerHeight = 56 const buttonContainerMarginTop = 4 @@ -48,7 +49,7 @@ function CalendarHeader({ > = {}