Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

fix edit task logs #212

Closed
wants to merge 1 commit into from

2 participants

@greywolfs

No description provided.

@caseysoftware

I think the original approach is more correct.

As noted in the comments just above this, you should only be able to edit a tasklog if you created the log, you are the subject of the log, or you have edit permission on the task.

@greywolfs greywolfs deleted the greywolfs:editTaskLogs branch
@greywolfs greywolfs restored the greywolfs:editTaskLogs branch
@greywolfs greywolfs deleted the greywolfs:editTaskLogs branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 28, 2013
  1. @greywolfs

    fix edit task logs

    greywolfs authored
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  modules/tasks/logs.class.php
View
2  modules/tasks/logs.class.php
@@ -346,7 +346,7 @@ public function canCreate() {
public function canEdit() {
if($this->_AppUI->user_id == $this->task_log_creator ||
$this->_AppUI->user_id == $this->task_log_record_creator ||
- $this->_perms->checkModuleItem($this->_tbl_module, 'edit', $this->{$this->_tbl_key})) {
+ $this->_perms->checkModuleItem($this->_tbl, 'edit', $this->{$this->_tbl_key})) {
return true;
}
Something went wrong with that request. Please try again.