Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug 1402, 1413, 1410 for projdesigner: moveTask was lethal, timecalculation wrong #239

Merged
merged 2 commits into from Nov 27, 2013

Conversation

Projects
None yet
2 participants
@opto
Copy link
Collaborator

commented Nov 26, 2013

bug 1410, 1st commit: in projectdesigner: ..comment out calcduration: 1) allow independent choice of start, end, duration 2) it calculates wrong, anyway
bug 1413, 1402:2. commit: move Tasks in projectdesigner can loose Tasks. Alternative CTask:moveTasksBetweenProjects is Buggy/ both FIXed
bug id 1410:

  1. on add Task in projectdesigner: when displaying line, duration is set to -3 hours
  2. on changing task end date by 2 days, duration is increased 8 hours (maybe working hours? but then it should be 16 hours).

this pull has commented the js function away. I think it is undesirable to force end=start + duration, and it calculates wrong, anyway.

Now: start, end and duration can be set independently. This probably happens more often than forcing end = start + duration. (like: between today and Friday, I work 3 hours on the Task - cannot currently be set in projectdesigner without this commit

bug id 1402, 1413: replace current move by changing Task_project which Forgets about children (which then are lost to both Projects) by CTask::moveTasksBetweenProjects Fix this funczion: it did not remove dependencies, it forgot to set Task_parent = Task_id for top Task, showing it indented in new projects' view

Klaus

K.Buecher added some commits Nov 26, 2013

opto
fix movetasks in projectdesigner, fix method Ctask::moveTaskBetweenPr…
…ojects, which does not remove dependencies and does not set task_parent

caseysoftware added a commit that referenced this pull request Nov 27, 2013

Merge pull request #239 from opto/projdes
fix bug 1402, 1413, 1410 for projdesigner: moveTask was lethal, timecalculation wrong

@caseysoftware caseysoftware merged commit de97cdb into web2project:master Nov 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.