Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added newer Recaptcha2 class to deal with v2.0. Fixes #919 #936

Merged
merged 1 commit into from May 3, 2015

Conversation

niphlod
Copy link
Member

@niphlod niphlod commented Apr 21, 2015

Improvements over the "old" v1.0

  • behaves well also without javascript
  • use_ssl is redundant, v2.0 works only in https mode
  • ajax is not useful anymore as the newer API is a lot easier

Adjusted also the addrow() method that was missing newer formstyles.

Improvements over the "old" v1.0
- behaves well also without javascript
- use_ssl is redundant, v2.0 works only in https mode
- ajax is not useful anymore as the newer API is a lot easier

Adjusted also the addrow() method that was missing newer formstyles.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 35.42% when pulling 77f154a on niphlod:enhancement/919 into f3bda9a on web2py:master.

@mdipierro
Copy link
Contributor

Do we have to call this Recaptcha2? can we replace the old one?

@niphlod
Copy link
Member Author

niphlod commented Apr 26, 2015

widgets dimensions aren't the same: it'll break existing designs, although it won't break functionality. Moreover, arguments for the old one don't match the newer. We can recommend this over the old, but not replace it.

@mdipierro
Copy link
Contributor

Can we expose a single interface that renders as one or the other depending on the arguments?

On Apr 26, 2015, at 1:34 PM, niphlod notifications@github.com wrote:

widgets dimensions aren't the same: it'll break existing designs, although it won't break functionality. Moreover, arguments for the old one don't match the newer. We can recommend this over the old, but not replace it.


Reply to this email directly or view it on GitHub.

@niphlod
Copy link
Member Author

niphlod commented Apr 28, 2015

Don't think so, sorry but they're too different.

@mdipierro
Copy link
Contributor

OK. But eventually we should break tools into sub modules.

@niphlod
Copy link
Member Author

niphlod commented Apr 28, 2015

you're preaching to a quire. Extrapolating recaptcha and recaptcha2 is by far the easiest sub-task in the great project of breaking tools.py.

@mdipierro
Copy link
Contributor

I think each class in tools is its own universe. They do not depend on each other.

mdipierro added a commit that referenced this pull request May 3, 2015
added newer Recaptcha2 class to deal with v2.0. Fixes #919
@mdipierro mdipierro merged commit 279d71d into web2py:master May 3, 2015
@niphlod niphlod deleted the enhancement/919 branch September 21, 2015 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants