From 5eea8bb916388b3203ac8c81db7ef9fe2b719b28 Mon Sep 17 00:00:00 2001 From: Samuel Furter Date: Tue, 31 Jul 2018 11:46:23 +0200 Subject: [PATCH 1/2] PR and issue template created --- ISSUE_TEMPLATE.md | 24 ++++++++++++++++++++++++ PULL_REQUEST_TEMPLATE.md | 26 ++++++++++++++++++++++++++ 2 files changed, 50 insertions(+) create mode 100644 ISSUE_TEMPLATE.md create mode 100644 PULL_REQUEST_TEMPLATE.md diff --git a/ISSUE_TEMPLATE.md b/ISSUE_TEMPLATE.md new file mode 100644 index 00000000000..882554f3eb8 --- /dev/null +++ b/ISSUE_TEMPLATE.md @@ -0,0 +1,24 @@ + + +#### Expected behavior + +#### Actual behavior + +#### Steps to reproduce the behavior + +1. [First step] +2. [Second step] +3. [and so on...] + +#### Logs + +#### Versions +[NPM, Node, Web3.js, OS, device...] diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 00000000000..bac5a8fbfc8 --- /dev/null +++ b/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,26 @@ +## Description + +Please include a summary of the change. + + + +## Type of change + +Please delete options that are not relevant. + +- [ ] Bug fix (non-breaking change which fixes an issue) +- [ ] New feature (non-breaking change which adds functionality) +- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) + +## Checklist: + +- [ ] I have selected the correct base branch. +- [ ] I have fixed the tests and extended if necessary. +- [ ] I have performed a self-review of my own code. +- [ ] I have commented my code, particularly in hard-to-understand areas. +- [ ] I have made corresponding changes to the documentation. +- [ ] My changes generate no new warnings. +- [ ] Any dependent changes have been merged and published in downstream modules. From 9daec9d707b28fd8e36ce6249bbc31694a6b9447 Mon Sep 17 00:00:00 2001 From: Samuel Furter Date: Tue, 31 Jul 2018 12:11:33 +0200 Subject: [PATCH 2/2] PR changes --- PULL_REQUEST_TEMPLATE.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index bac5a8fbfc8..8c7b3a17290 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -9,7 +9,7 @@ Fixes #(issue) ## Type of change -Please delete options that are not relevant. + - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) @@ -18,9 +18,11 @@ Please delete options that are not relevant. ## Checklist: - [ ] I have selected the correct base branch. -- [ ] I have fixed the tests and extended if necessary. - [ ] I have performed a self-review of my own code. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have made corresponding changes to the documentation. - [ ] My changes generate no new warnings. - [ ] Any dependent changes have been merged and published in downstream modules. +- [ ] I ran ```npm run test``` with success and extended the tests if necessary. +- [ ] I ran ```npm run build``` and tested the resulting file from ```dist``` folder in a browser. +- [ ] I have tested my code on the live network.