Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning of BigNumber objects instead of strings #2570

Closed
nivida opened this issue Mar 25, 2019 · 3 comments
Closed

Returning of BigNumber objects instead of strings #2570

nivida opened this issue Mar 25, 2019 · 3 comments
Labels
Enhancement Includes improvements or optimizations

Comments

@nivida
Copy link
Contributor

nivida commented Mar 25, 2019

Description

It's returning strings instead of BigNumber objects on a contract method call.

Expected behavior

Returns a BigNumber object instead of a string.

Actual behavior

Returns a number as string.

Steps to reproduce the behavior

contract.methods.method().send().then(console.log);

Error Logs

Versions

  • web3.js: latest
@Anaphase
Copy link

Man, this breaking change really messed up my codebase :(

@nivida
Copy link
Contributor Author

nivida commented Apr 11, 2019

Yes, I see your point. But the decision was between a working react native production build or this breaking change. This was the reason why I‘ve decided to release this breaking change. I‘ve apologize for the troubles.

@levino
Copy link
Contributor

levino commented Apr 15, 2019

IMO: It would be much better if only strings were returned or required by all methods of web3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Includes improvements or optimizations
Projects
None yet
Development

No branches or pull requests

3 participants