Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribe to context events if contractContext instanceof Web3Context #5833

Merged
merged 4 commits into from
Feb 14, 2023

Conversation

spacesailor24
Copy link
Contributor

@spacesailor24 spacesailor24 commented Feb 14, 2023

closes #5817

@github-actions
Copy link

github-actions bot commented Feb 14, 2023

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 1.18 MB 1.06 MB -121 KB -10.01%
View detailed bundle breakdown

Added

Asset Old size New size Diff Diff %
../lib/eth.exports.d.ts.map 0 358 bytes 358 bytes -
../lib/eth.exports.d.ts 0 321 bytes 321 bytes -
../lib/providers.exports.d.ts.map 0 292 bytes 292 bytes -
../lib/providers.exports.d.ts 0 238 bytes 238 bytes -

Removed

No assets were removed

Bigger

Asset Old size New size Diff Diff %
../lib/index.d.ts 77 bytes 899 bytes 822 bytes 1067.53%
../lib/index.d.ts.map 155 bytes 919 bytes 764 bytes 492.90%

Smaller

Asset Old size New size Diff Diff %
web3.min.js 1.17 MB 1.05 MB -123 KB -10.29%
../lib/types.d.ts 1.92 KB 1.68 KB -253 bytes -12.84%
../lib/types.d.ts.map 1.75 KB 1.51 KB -241 bytes -13.46%

Unchanged

Asset Old size New size Diff Diff %
../lib/accounts.d.ts 3.42 KB 3.42 KB 0 0.00%
../lib/abi.d.ts 1020 bytes 999 bytes -18 bytes -1.77%
../lib/web3.d.ts 842 bytes 842 bytes 0 0.00%
../lib/web3.d.ts.map 693 bytes 694 bytes 1 bytes 0.14%
../lib/accounts.d.ts.map 528 bytes 528 bytes 0 0.00%
../lib/version.d.ts.map 140 bytes 140 bytes 0 0.00%
../lib/abi.d.ts.map 124 bytes 124 bytes 0 0.00%
../lib/version.d.ts 97 bytes 97 bytes 0 0.00%

@github-actions github-actions bot temporarily deployed to Preview: (wyatt/4.x/5817-suscribeToGlobalEvents-refactors) February 14, 2023 04:40 Inactive
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 14, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4b7d869
Status: ✅  Deploy successful!
Preview URL: https://92b747b2.web3-js-docs.pages.dev
Branch Preview URL: https://wyatt-4-x-5817-suscribetoglo.web3-js-docs.pages.dev

View logs

@spacesailor24 spacesailor24 self-assigned this Feb 14, 2023
@spacesailor24 spacesailor24 added the 4.x 4.0 related label Feb 14, 2023
@spacesailor24 spacesailor24 marked this pull request as ready for review February 14, 2023 05:50
@github-actions github-actions bot temporarily deployed to Preview: (wyatt/4.x/5817-suscribeToGlobalEvents-refactors) February 14, 2023 05:55 Inactive
@github-actions github-actions bot temporarily deployed to Preview: (wyatt/4.x/5817-suscribeToGlobalEvents-refactors) February 14, 2023 06:02 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x 4.0 related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants