Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Hardware Wallet support #117

Open
wants to merge 12 commits into
base: master
from
Open

add Hardware Wallet support #117

wants to merge 12 commits into from

Conversation

@pedrouid
Copy link
Member

pedrouid commented Feb 4, 2020

  • add Ledger connector
  • add Trezor connector
pedrouid added 3 commits Feb 1, 2020
…onnect into hardware-wallet-support
This was referenced Feb 4, 2020
@pedrouid

This comment has been minimized.

Copy link
Member Author

pedrouid commented Feb 4, 2020

@pedrouid pedrouid marked this pull request as ready for review Feb 4, 2020
pedrouid added 3 commits Feb 4, 2020
@lukasschor

This comment has been minimized.

Copy link

lukasschor commented Feb 5, 2020

@pedrouid What are the steps required to connect a ledger device?
I have my device connected using USB & unlocked. Yet, when I choose the ledger option, the modal just closes without anything happening.

@pedrouid

This comment has been minimized.

Copy link
Member Author

pedrouid commented Feb 5, 2020

Hey @lukasschor, unfortunately this is not actually working. The issue is related to the Ledger and Trezor providers themselves which were made custom for web3connect but need to be fixed.

Ledger Provider: https://github.com/web3connect/ledger-provider
Trezor Provider: https://github.com/web3connect/trezor-provider

Alternatively if anyone has knowledge of a better provider implementation for both, please let me know and we can update this PR accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.