Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dependency injection #79

Merged
merged 10 commits into from Sep 15, 2019

Conversation

@pedrouid
Copy link
Member

commented Sep 3, 2019

No description provided.

pedrouid added 2 commits Sep 3, 2019
src/helpers/utils.ts Outdated Show resolved Hide resolved
src/helpers/utils.ts Outdated Show resolved Hide resolved
pedrouid added 2 commits Sep 4, 2019

@pedrouid pedrouid changed the title Handle unavailable provider packages Use dependency injection Sep 14, 2019

pedrouid added 2 commits Sep 14, 2019
@dkent600

This comment has been minimized.

Copy link
Contributor

commented on src/core/connectors/walletconnect.ts in ce364cd Sep 14, 2019

Maybe to be consistent with its sibling functions, this should be async?

This comment has been minimized.

Copy link
Member Author

replied Sep 14, 2019

Actually some of them of shouldn't be async if they already return a Promise but thanks for pointing it out

@pedrouid pedrouid merged commit f4e84f5 into master Sep 15, 2019

2 of 5 checks passed

Header rules No header rules processed
Details
Pages changed 6 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
deploy/netlify Deploy preview ready!
Details

@pedrouid pedrouid deleted the beta.21 branch Sep 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.