New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix web3j#152. Filters create requests based on type #154

Merged
merged 3 commits into from Sep 6, 2017

Conversation

Projects
None yet
3 participants
@the-wastl
Contributor

the-wastl commented Aug 25, 2017

Not all filters can provide historic data. In fact only the LogFilter can. Thus all other filters (i.e. BlockFilter and PendingTransactionFilter) must use the ethGetFilterChanges method instead of ethGetFilterLogs

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 25, 2017

Codecov Report

Merging #154 into master will increase coverage by 0.01%.
The diff coverage is 69.23%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #154      +/-   ##
============================================
+ Coverage     79.57%   79.58%   +0.01%     
- Complexity     1231     1236       +5     
============================================
  Files           179      179              
  Lines          4269     4281      +12     
  Branches        654      655       +1     
============================================
+ Hits           3397     3407      +10     
- Misses          698      699       +1     
- Partials        174      175       +1
Impacted Files Coverage Δ Complexity Δ
...a/org/web3j/protocol/core/filters/BlockFilter.java 76.92% <100%> (+1.92%) 5 <1> (+1) ⬆️
...rotocol/core/filters/PendingTransactionFilter.java 76.92% <100%> (+1.92%) 5 <1> (+1) ⬆️
...ava/org/web3j/protocol/core/filters/LogFilter.java 78.57% <100%> (+1.64%) 5 <1> (+1) ⬆️
...n/java/org/web3j/protocol/core/filters/Filter.java 58.33% <65.21%> (+1.57%) 6 <3> (+2) ⬆️
src/main/java/org/web3j/crypto/Wallet.java 84.04% <0%> (+1.75%) 14% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ada4d03...552bf55. Read the comment docs.

codecov-io commented Aug 25, 2017

Codecov Report

Merging #154 into master will increase coverage by 0.01%.
The diff coverage is 69.23%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #154      +/-   ##
============================================
+ Coverage     79.57%   79.58%   +0.01%     
- Complexity     1231     1236       +5     
============================================
  Files           179      179              
  Lines          4269     4281      +12     
  Branches        654      655       +1     
============================================
+ Hits           3397     3407      +10     
- Misses          698      699       +1     
- Partials        174      175       +1
Impacted Files Coverage Δ Complexity Δ
...a/org/web3j/protocol/core/filters/BlockFilter.java 76.92% <100%> (+1.92%) 5 <1> (+1) ⬆️
...rotocol/core/filters/PendingTransactionFilter.java 76.92% <100%> (+1.92%) 5 <1> (+1) ⬆️
...ava/org/web3j/protocol/core/filters/LogFilter.java 78.57% <100%> (+1.64%) 5 <1> (+1) ⬆️
...n/java/org/web3j/protocol/core/filters/Filter.java 58.33% <65.21%> (+1.57%) 6 <3> (+2) ⬆️
src/main/java/org/web3j/crypto/Wallet.java 84.04% <0%> (+1.75%) 14% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ada4d03...552bf55. Read the comment docs.

@conor10

Thanks for highlighting this.

I'd be grateful if you can incorporate some of the below modifications.

@the-wastl

This comment has been minimized.

Show comment
Hide comment
@the-wastl

the-wastl Sep 4, 2017

Contributor

All filters that do not support fetching a full log, now return an empty optional and the initial fetching works async now

Contributor

the-wastl commented Sep 4, 2017

All filters that do not support fetching a full log, now return an empty optional and the initial fetching works async now

@conor10 conor10 merged commit 933eb0b into web3j:master Sep 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@conor10

This comment has been minimized.

Show comment
Hide comment
@conor10

conor10 Sep 6, 2017

Collaborator

Awesome - thanks @the-wastl.

Collaborator

conor10 commented Sep 6, 2017

Awesome - thanks @the-wastl.

franz-see pushed a commit to franz-see/web3j that referenced this pull request Aug 3, 2018

franz-see pushed a commit to franz-see/web3j that referenced this pull request Aug 3, 2018

Merge pull request web3j#154 from the-wastl/master
Fix web3j#152. Filters create requests based on type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment