New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCrypt replaced with spongycastle #165

Merged
merged 3 commits into from Sep 4, 2017

Conversation

Projects
None yet
4 participants
@dmitrychaban
Contributor

dmitrychaban commented Sep 3, 2017

Removed SCrypt library and replaced SCrypt class with one from spongycastle for Play Market compatibility
fixes #157

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Sep 3, 2017

Codecov Report

Merging #165 into android will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             android    #165      +/-   ##
============================================
+ Coverage      79.39%   79.4%   +<.01%     
  Complexity      1161    1161              
============================================
  Files            164     164              
  Lines           4309    4301       -8     
  Branches         640     640              
============================================
- Hits            3421    3415       -6     
+ Misses           746     744       -2     
  Partials         142     142
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/web3j/crypto/Wallet.java 75.7% <100%> (+1.38%) 14 <1> (ø) ⬇️
...protocol/core/methods/response/EthTransaction.java 28.57% <0%> (-14.29%) 2% <0%> (ø)
...ore/methods/response/EthGetTransactionReceipt.java 28.57% <0%> (-14.29%) 2% <0%> (ø)
.../parity/methods/response/PersonalAccountsInfo.java 90.62% <0%> (-0.29%) 2% <0%> (ø)
...3j/protocol/core/methods/response/ShhMessages.java 95.29% <0%> (-0.06%) 2% <0%> (ø)
...ava/org/web3j/codegen/SolidityFunctionWrapper.java 98.67% <0%> (-0.01%) 55% <0%> (ø)
.../org/web3j/protocol/infura/CertificateManager.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ocol/core/methods/response/EthCompileSolidity.java 100% <0%> (ø) 2% <0%> (ø) ⬇️
src/main/java/org/web3j/crypto/Sign.java 68.26% <0%> (+0.65%) 12% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45451f5...51d8eee. Read the comment docs.

codecov-io commented Sep 3, 2017

Codecov Report

Merging #165 into android will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             android    #165      +/-   ##
============================================
+ Coverage      79.39%   79.4%   +<.01%     
  Complexity      1161    1161              
============================================
  Files            164     164              
  Lines           4309    4301       -8     
  Branches         640     640              
============================================
- Hits            3421    3415       -6     
+ Misses           746     744       -2     
  Partials         142     142
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/web3j/crypto/Wallet.java 75.7% <100%> (+1.38%) 14 <1> (ø) ⬇️
...protocol/core/methods/response/EthTransaction.java 28.57% <0%> (-14.29%) 2% <0%> (ø)
...ore/methods/response/EthGetTransactionReceipt.java 28.57% <0%> (-14.29%) 2% <0%> (ø)
.../parity/methods/response/PersonalAccountsInfo.java 90.62% <0%> (-0.29%) 2% <0%> (ø)
...3j/protocol/core/methods/response/ShhMessages.java 95.29% <0%> (-0.06%) 2% <0%> (ø)
...ava/org/web3j/codegen/SolidityFunctionWrapper.java 98.67% <0%> (-0.01%) 55% <0%> (ø)
.../org/web3j/protocol/infura/CertificateManager.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ocol/core/methods/response/EthCompileSolidity.java 100% <0%> (ø) 2% <0%> (ø) ⬇️
src/main/java/org/web3j/crypto/Sign.java 68.26% <0%> (+0.65%) 12% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45451f5...51d8eee. Read the comment docs.

@conor10 conor10 merged commit 02262dc into web3j:android Sep 4, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dmitrychaban dmitrychaban changed the title from [WIP] SCrypt replaced with spongycastle to SCrypt replaced with spongycastle Sep 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment