New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow range observable to emit 1 value #184

Merged
merged 1 commit into from Oct 11, 2017

Conversation

Projects
None yet
2 participants
@iikirilov
Member

iikirilov commented Oct 9, 2017

No description provided.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 9, 2017

Codecov Report

Merging #184 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #184      +/-   ##
============================================
+ Coverage     79.36%   79.39%   +0.03%     
- Complexity     1466     1468       +2     
============================================
  Files           195      195              
  Lines          5291     5291              
  Branches        873      873              
============================================
+ Hits           4199     4201       +2     
  Misses          898      898              
+ Partials        194      192       -2
Impacted Files Coverage Δ Complexity Δ
...ore/src/main/java/org/web3j/utils/Observables.java 88% <100%> (+8%) 11 <0> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d809866...05e845c. Read the comment docs.

codecov bot commented Oct 9, 2017

Codecov Report

Merging #184 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #184      +/-   ##
============================================
+ Coverage     79.36%   79.39%   +0.03%     
- Complexity     1466     1468       +2     
============================================
  Files           195      195              
  Lines          5291     5291              
  Branches        873      873              
============================================
+ Hits           4199     4201       +2     
  Misses          898      898              
+ Partials        194      192       -2
Impacted Files Coverage Δ Complexity Δ
...ore/src/main/java/org/web3j/utils/Observables.java 88% <100%> (+8%) 11 <0> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d809866...05e845c. Read the comment docs.

@conor10 conor10 merged commit 3fba09d into web3j:master Oct 11, 2017

3 checks passed

codecov/patch 100% of diff hit (target 79.36%)
Details
codecov/project 79.39% (+0.03%) compared to d809866
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@conor10

This comment has been minimized.

Show comment
Hide comment
@conor10

conor10 Oct 11, 2017

Collaborator

Thanks.

Collaborator

conor10 commented Oct 11, 2017

Thanks.

franz-see pushed a commit to franz-see/web3j that referenced this pull request Aug 3, 2018

Merge pull request web3j#184 from iikirilov/master
allow range observable to emit 1 value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment