New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor addHeaders() in HttpService allowing customize headers. #200

Merged
merged 2 commits into from Oct 24, 2017

Conversation

Projects
None yet
2 participants
@mawenpeng

mawenpeng commented Oct 23, 2017

Users may need customized headers if they access Ethereum via a reverse proxy or a gateway.
The customized headers may be used for authentication or give some other info to the reverse proxy or gateway.

I refactored the code to allow users to customize headers.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 23, 2017

Codecov Report

Merging #200 into master will increase coverage by 0.15%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #200      +/-   ##
============================================
+ Coverage     76.98%   77.14%   +0.15%     
- Complexity     1474     1479       +5     
============================================
  Files           201      201              
  Lines          5453     5455       +2     
  Branches        884      884              
============================================
+ Hits           4198     4208      +10     
+ Misses         1061     1051      -10     
- Partials        194      196       +2
Impacted Files Coverage Δ Complexity Δ
...a/org/web3j/protocol/infura/InfuraHttpService.java 38.46% <0%> (+2.74%) 4 <0> (ø) ⬇️
...main/java/org/web3j/protocol/http/HttpService.java 80% <100%> (+13.87%) 17 <4> (+6) ⬆️
...ore/src/main/java/org/web3j/utils/Observables.java 80% <0%> (-4%) 9% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66019e8...893cab1. Read the comment docs.

codecov bot commented Oct 23, 2017

Codecov Report

Merging #200 into master will increase coverage by 0.15%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #200      +/-   ##
============================================
+ Coverage     76.98%   77.14%   +0.15%     
- Complexity     1474     1479       +5     
============================================
  Files           201      201              
  Lines          5453     5455       +2     
  Branches        884      884              
============================================
+ Hits           4198     4208      +10     
+ Misses         1061     1051      -10     
- Partials        194      196       +2
Impacted Files Coverage Δ Complexity Δ
...a/org/web3j/protocol/infura/InfuraHttpService.java 38.46% <0%> (+2.74%) 4 <0> (ø) ⬇️
...main/java/org/web3j/protocol/http/HttpService.java 80% <100%> (+13.87%) 17 <4> (+6) ⬆️
...ore/src/main/java/org/web3j/utils/Observables.java 80% <0%> (-4%) 9% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66019e8...893cab1. Read the comment docs.

mawp

@mawenpeng mawenpeng changed the title from Refactor addHeaders() allowing customized headers. to Refactor addHeaders() in HttpService allowing customize headers. Oct 24, 2017

@conor10 conor10 merged commit e44e9a5 into web3j:master Oct 24, 2017

3 checks passed

codecov/patch 85.71% of diff hit (target 76.98%)
Details
codecov/project 77.14% (+0.15%) compared to 66019e8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@conor10

This comment has been minimized.

Show comment
Hide comment
@conor10

conor10 Oct 24, 2017

Collaborator

Thanks!

Collaborator

conor10 commented Oct 24, 2017

Thanks!

franz-see pushed a commit to franz-see/web3j that referenced this pull request Aug 3, 2018

Merge pull request web3j#200 from mawenpeng/master
Refactor addHeaders() in HttpService allowing customize headers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment