New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the duplicated calls for installing and uninstalling the filter #212

Merged
merged 1 commit into from Oct 30, 2017

Conversation

Projects
None yet
2 participants
@mochalovv

mochalovv commented Oct 30, 2017

Investigating the #211 issue, I found out that eth_uninstallFilter method is called twice. The first call is successful, but the second call causes an exception as its result is false:
{"jsonrpc":"2.0","id":1,"result":false}.

This pull request fixes the issue.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 30, 2017

Codecov Report

Merging #212 into android will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             android     #212      +/-   ##
=============================================
- Coverage      76.35%   76.33%   -0.03%     
  Complexity      1466     1466              
=============================================
  Files            197      197              
  Lines           5562     5556       -6     
  Branches         898      898              
=============================================
- Hits            4247     4241       -6     
  Misses          1118     1118              
  Partials         197      197
Impacted Files Coverage Δ Complexity Δ
.../main/java/org/web3j/protocol/rx/JsonRpc2_0Rx.java 70.87% <ø> (-1.61%) 18 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5097900...ca3c9e6. Read the comment docs.

codecov bot commented Oct 30, 2017

Codecov Report

Merging #212 into android will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             android     #212      +/-   ##
=============================================
- Coverage      76.35%   76.33%   -0.03%     
  Complexity      1466     1466              
=============================================
  Files            197      197              
  Lines           5562     5556       -6     
  Branches         898      898              
=============================================
- Hits            4247     4241       -6     
  Misses          1118     1118              
  Partials         197      197
Impacted Files Coverage Δ Complexity Δ
.../main/java/org/web3j/protocol/rx/JsonRpc2_0Rx.java 70.87% <ø> (-1.61%) 18 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5097900...ca3c9e6. Read the comment docs.

@conor10 conor10 merged commit 001c1cd into web3j:android Oct 30, 2017

2 of 3 checks passed

codecov/project 76.33% (-0.03%) compared to 5097900
Details
codecov/patch Coverage not affected when comparing 5097900...ca3c9e6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@conor10

This comment has been minimized.

Show comment
Hide comment
@conor10

conor10 Oct 30, 2017

Collaborator

Thanks for spotting.

Collaborator

conor10 commented Oct 30, 2017

Thanks for spotting.

@mochalovv mochalovv deleted the mochalovv:fix/issue_#211 branch Oct 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment