New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import test dependencies from testArtifacts rather than archives. #455

Merged
merged 1 commit into from Apr 3, 2018

Conversation

Projects
None yet
2 participants
@p-s-dev
Contributor

p-s-dev commented Mar 27, 2018

Building always worked from the command line. However, IntelliJ refused to accept the "archives" configuration as a valid source for test dependencies. By defining a new configuration "testArtifacts" and exporting it from the subprojects that contain shared test classes, I'm able to open the project in IntelliJ and compile it with no "can not find symbol" errors in the cross-project imports.

Also Removed a duplicate TempFileProvider class and change to dependency reference.

psdev
import test dependencies from testArtifacts rather than archives. Rem…
…ove duplicate TempFileProvider class and change to dependency reference.
@codecov

This comment has been minimized.

codecov bot commented Mar 27, 2018

Codecov Report

Merging #455 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #455      +/-   ##
============================================
+ Coverage      76.6%   76.61%   +0.01%     
- Complexity     1635     1636       +1     
============================================
  Files           215      215              
  Lines          6129     6129              
  Branches        961      961              
============================================
+ Hits           4695     4696       +1     
  Misses         1203     1203              
+ Partials        231      230       -1
Impacted Files Coverage Δ Complexity Δ
...ore/src/main/java/org/web3j/utils/Observables.java 84% <0%> (+4%) 10% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d53933e...267fef9. Read the comment docs.

@conor10 conor10 merged commit fc1d053 into web3j:master Apr 3, 2018

3 checks passed

codecov/patch Coverage not affected when comparing d53933e...267fef9
Details
codecov/project 76.61% (+0.01%) compared to d53933e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@conor10

This comment has been minimized.

Collaborator

conor10 commented Apr 3, 2018

Thanks! 👍

franz-see pushed a commit to franz-see/web3j that referenced this pull request Aug 3, 2018

Merge pull request web3j#455 from p-s-dev/gradleTestDeps
import test dependencies from testArtifacts rather than archives.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment