New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix List<Boolean> type transfer bug #534

Merged
merged 1 commit into from Jul 5, 2018

Conversation

Projects
None yet
2 participants
@mmmmmagina
Contributor

mmmmmagina commented May 9, 2018

In abi generated code, below code will raise a error : "org.web3j.abi.TypeMappingException: java.lang.NoSuchMethodException: org.web3j.abi.datatypes.Bool.(java.lang.Boolean)"

new org.web3j.abi.datatypes.DynamicArray<org.web3j.abi.datatypes.Bool>(
org.web3j.abi.Utils.typeMap(boolListParams, org.web3j.abi.datatypes.Bool.class)),

because of the Bool.class has contructor method with param boolean but not Boolean

fix List<Boolean> type transfer bug
In abi generated code,  below code will raise a error : "org.web3j.abi.TypeMappingException: java.lang.NoSuchMethodException: org.web3j.abi.datatypes.Bool.<init>(java.lang.Boolean)"

new org.web3j.abi.datatypes.DynamicArray<org.web3j.abi.datatypes.Bool>(
                        org.web3j.abi.Utils.typeMap(boolListParams, org.web3j.abi.datatypes.Bool.class)),

because of the Bool.class has contructor method with param boolean  but not Boolean
@codecov

This comment has been minimized.

codecov bot commented May 9, 2018

Codecov Report

Merging #534 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #534      +/-   ##
============================================
- Coverage     76.87%   76.84%   -0.03%     
- Complexity     1686     1687       +1     
============================================
  Files           222      222              
  Lines          6295     6298       +3     
  Branches        972      972              
============================================
+ Hits           4839     4840       +1     
- Misses         1215     1218       +3     
+ Partials        241      240       -1
Impacted Files Coverage Δ Complexity Δ
...bi/src/main/java/org/web3j/abi/datatypes/Bool.java 43.75% <0%> (-10.1%) 5 <0> (ø)
...ore/src/main/java/org/web3j/utils/Observables.java 84% <0%> (+4%) 10% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f477549...caa00d8. Read the comment docs.

@conor10

This comment has been minimized.

Collaborator

conor10 commented May 10, 2018

@mmmmmagina - please can you provide a test that demonstrates this?

@conor10 conor10 merged commit 716ae3f into web3j:master Jul 5, 2018

1 of 3 checks passed

codecov/patch 0% of diff hit (target 76.87%)
Details
codecov/project 76.84% (-0.03%) compared to f477549
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

franz-see pushed a commit to franz-see/web3j that referenced this pull request Aug 3, 2018

Merge pull request web3j#534 from mmmmmagina/master
fix List<Boolean> type transfer bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment