New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows searching in Favorites, as in webOS 1.x and 2.x #24

Merged
merged 3 commits into from Dec 7, 2016

Conversation

Projects
None yet
3 participants
@DougReeder
Contributor

DougReeder commented Dec 6, 2016

Increases # rows displayed while searching All by 33%, by using InputSearchStretch in tab toolbar. Thus, the functionality is similar to Mojo Just Type.

Open-WebOS-DCO-1.0-Signed-Off-By: Doug Reeder reeder.29@gmail.com

DougReeder added some commits Nov 30, 2016

Allows searching in Favorites, as in webOS 1.x and 2.x
Increases # rows displayed while searching All by 33%, by using InputSearchStretch in tab toolbar.
Thus, the functionality is similar to Mojo Just Type.
Open-WebOS-DCO-1.0-Signed-Off-By: Doug Reeder reeder.29@gmail.com
Cleanup of un-needed Controls.
Open-WebOS-DCO-1.0-Signed-Off-By: Doug Reeder reeder.29@gmail.com
Width of search field is limited to about 14 characters.
Open-WebOS-DCO-1.0-Signed-Off-By: Doug Reeder reeder.29@gmail.com
@DougReeder

This comment has been minimized.

Show comment
Hide comment
@DougReeder

DougReeder Dec 7, 2016

Contributor

Live demo at https://hominidsoftware.com/Contacts/
Narrow the window to phone or phablet width (better yet, use a phone or tablet with virtual keyboard) to get a proper sense of how it feels.

Contributor

DougReeder commented Dec 7, 2016

Live demo at https://hominidsoftware.com/Contacts/
Narrow the window to phone or phablet width (better yet, use a phone or tablet with virtual keyboard) to get a proper sense of how it feels.

@Herrie82 Herrie82 merged commit 3af2062 into webOS-ports:master Dec 7, 2016

@girliemac

This comment has been minimized.

Show comment
Hide comment
@girliemac

girliemac Dec 11, 2016

Pretty sleek 😎 and responsive to various form factors!

This may not be directly related to the PR, but if you want to tweak more with the UI, I have a few things I can say:

  • Better stick with fewer gray variants. I can spot at least 5 diff grays w/o checking with the Inspector. Some look too close to each other (e.g. #222 and #333).
  • I don't think shifting the position of the star when being clicked. I think the yellow color indicator is good but the down-state on click seems overdone.
  • Use text-shadow: 0px 1px 0px #fff; for each contact name on the left column (on light gray background color)

🐱

girliemac commented Dec 11, 2016

Pretty sleek 😎 and responsive to various form factors!

This may not be directly related to the PR, but if you want to tweak more with the UI, I have a few things I can say:

  • Better stick with fewer gray variants. I can spot at least 5 diff grays w/o checking with the Inspector. Some look too close to each other (e.g. #222 and #333).
  • I don't think shifting the position of the star when being clicked. I think the yellow color indicator is good but the down-state on click seems overdone.
  • Use text-shadow: 0px 1px 0px #fff; for each contact name on the left column (on light gray background color)

🐱

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment