Исправлен бесконечный вызов shopProductsCollection::prepare() в кастомных коллекциях. #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZloyTip
commented
Sep 16, 2016
| } | ||
| } | ||
|
|
||
| if ($this->prepared) { |
Contributor
Author
|
О, как удобно что не приняли PR. Столкнулся ещё раз стой же ошибкой, а тут и патч готов. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Даже не знаю как правильно описать :)
Столкнулся с ошибкой.
Если плагин пытается добавить сортировку через публичный метод orderBy, возникает бесконечный рекурсивный вызов.
Происходит из-за того, что в orderBy вызывается getSQL
http://dl1.joxi.net/drive/2016/09/16/0009/0563/614963/63/2486b3137e.jpg
а getSQL вызывает prepare, который ещё не prepared.
Сакральный смысл вызова getSQL я не понял, поэтому решил не трогать, а объявил prepared=true до вызова плагинов. Если ни один плагин не сработает, всё-равно будет брошено исключение.
Ну и за компанию
if ($this->prepared) {
return;
}
в том месте лишено всякого смысла.