add sword grunt #3660
Closed
add sword grunt #3660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avaer
reviewed
Aug 23, 2022
character-sfx.js
Outdated
| currentCombo = this.player.getAction('use').animation ? | ||
| this.player.getAction('use').animation // sword | ||
| : | ||
| this.player.getAction('use').animationCombo[this.player.avatar.useAnimationIndex] // silsword |
There was a problem hiding this comment.
Why is this mentioning app names? Apps have nothing to do with the engine.
avaer
reviewed
Aug 23, 2022
character-sfx.js
Outdated
|
|
||
| // combo | ||
| const dispatchComboSoundEvent = (combo, indexOfCombo) =>{ | ||
| this.dispatchEvent(new MessageEvent('comboSoundEmit', { |
There was a problem hiding this comment.
This is a poor name for the event, not consistent with other events.
There was a problem hiding this comment.
Got it. Renamed event
webaverse/silsword@5d403c4
38d71b6
avaer
reviewed
Aug 23, 2022
character-sfx.js
Outdated
| this.currentComboIndex = 0; | ||
| } | ||
| case 0: { | ||
| if(timestamp - this.playComboTime >= swordAnimationOffset[this.currentComboIndex]){ |
There was a problem hiding this comment.
Given that this code is repeated, this is not a good way to write this method. There should not be any numerical state machine.
There was a problem hiding this comment.
got it.
remove state machine
|
I think the Both sword types/combo types should have the sword whoosh. The event name could be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #3659
Sibling:
webaverse/silsword#12
sword does not have index.js to play its whoosh sound. Should I play the sound in totum?
Result:
Webaverse.-.Google.Chrome.2022-08-22.16-21-46.mp4