Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

attempt to fix tests for Travis #116

Merged
merged 2 commits into from Apr 23, 2013

Conversation

Projects
None yet
2 participants
Contributor

pk11 commented Apr 21, 2013

  • replace HttpCookie.parse with netty CookieDecoder for jdk6 compatibility
  • increase wait time for timing dependent tests so a slower CI server won't time out
@pk11 pk11 attempt to fix tests for Travis
- replace HttpCookie.parse with netty CookieDecoder for jdk6 compatibility
- increase wait time for timing dependent tests so a slower CI server won't time out
974ea79
Owner

aslakhellesoy commented Apr 21, 2013

@pk11 can you merge with webbit's master so travis can build it for us?

Contributor

pk11 commented Apr 21, 2013

@aslakhellesoy sure, done.

Contributor

pk11 commented Apr 21, 2013

@aslakhellesoy as far as I can tell the current issue is related to Travis to some degree i.e. java.lang.OutOfMemoryError: unable to create new native thread

For what's it worth the tests are executing just fine on dedicated machines( I tested with linux for jdk6 and oracle jdk7 on os x)

Contributor

pk11 commented Apr 22, 2013

@aslakhellesoy is it possible to increase the heap size used by maven on the CI server?
ie
export MAVEN_OPTS=-Xmx1024m

@aslakhellesoy aslakhellesoy merged commit 174b73d into webbit:master Apr 23, 2013

1 check failed

default The Travis build could not complete due to an error
Details
Owner

aslakhellesoy commented Apr 23, 2013

Increasing heap size didn't help it seems: https://travis-ci.org/webbit/webbit/jobs/6557552
Now it fails on openjdk6. Seems related to travis-ci/travis-ci#848

@aslakhellesoy aslakhellesoy added a commit that referenced this pull request Apr 23, 2013

@aslakhellesoy aslakhellesoy Another attempt at #116. d91823c
Owner

aslakhellesoy commented Apr 23, 2013

Increasing the heap size doesn't seem to help either. Looking at the numerous warning messages from NettyWebServerTest.startAndStop() it seems like Netty 3.6.5 isn't properly stopping threads and allowing them to be GC'ed. With Netty 3.6.5 the warning messages are printed a lot of times (suggesting a Netty memory leak). With Netty 3.5.3 it's only printed zero times or once on my machine, which suggests less (or perhaps even no) memory leaks.

Contributor

pk11 commented Apr 23, 2013

@aslakhellesoy that's strange - I wonder why I never saw these issues locally. Anyway, I am glad Travis is now working.

as for the netty downgrade, should not we change the bundled library as well? https://github.com/webbit/webbit/tree/master/lib

Owner

aslakhellesoy commented Apr 23, 2013

Yes, I'll update lib files as well.

Contributor

pk11 commented Apr 23, 2013

going through netty's changelog and issues, I found this netty/netty#616 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment