Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beforeChange handler and loading class/state #359

Merged
merged 5 commits into from Aug 24, 2019
Merged

Add beforeChange handler and loading class/state #359

merged 5 commits into from Aug 24, 2019

Conversation

kameelyan
Copy link

I wanted to add a loading state to this, as I'm working on a project where we save the response immediately to the server, and only want to move the check if that save is successful.

Looked at the open issues and saw the before change request, so I added that too since we can use that for this purpose as well.
#314

beforeChange is an Input that accepts an Observable that returns a boolean. If the boolean is true, the click event continues as normal. If no observable exists, the code continues as normal.

I updated the class to display it as flex and align/justify the items to center. This is more precise centering with icons that the example and flex has like 95%+ compatibility.
https://caniuse.com/#feat=flexbox

Also added some examples.

@cmckni3 cmckni3 merged commit 33ac097 into webcat12345:master Aug 24, 2019
@cmckni3
Copy link
Collaborator

cmckni3 commented Aug 24, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants